Merge pull request #9 from aucampia/iwana-20211219T2004-type_new

Type __new__ instead of adding __init__

3 files changed, 11 insertions, 21 deletions

diff --git a/rdflib/namespace/__init__.py b/rdflib/namespace/__init__.py
index bf019e24..80ede21e 100644
--- a/rdflib/namespace/__init__.py
+++ b/rdflib/namespace/__init__.py
@@ -1,6 +1,6 @@
 import logging
 import warnings
-from typing import List
+from typing import TYPE_CHECKING, List, Union
 from unicodedata import category
 
 from pathlib import Path
@@ -101,14 +101,11 @@ class Namespace(str):
     False
     """
 
-    def __init__(self, *args, **kwargs) -> None:
-        super().__init__()
-
-    def __new__(cls, value):
+    def __new__(cls, value: Union[str, bytes]) -> "Namespace":
         try:
             rt = str.__new__(cls, value)
         except UnicodeDecodeError:
-            rt = str.__new__(cls, value, "utf-8")
+            rt = str.__new__(cls, value, "utf-8")  # type: ignore[arg-type]
         return rt
 
     @property
diff --git a/rdflib/term.py b/rdflib/term.py
index 70f3a013..38ad5c5a 100644
--- a/rdflib/term.py
+++ b/rdflib/term.py
@@ -129,10 +129,7 @@ class Identifier(Node, str):  # allow Identifiers to be Nodes in the Graph
 
     __slots__ = ()
 
-    def __init__(self, *args, **kwargs) -> None:
-        super().__init__(*args, **kwargs)
-
-    def __new__(cls, value):
+    def __new__(cls, value: str) -> "Identifier":
         return str.__new__(cls, value)
 
     def eq(self, other):
@@ -401,12 +398,12 @@ class BNode(Identifier):
 
     __slots__ = ()
 
-    def __init__(self, *args, **kwargs) -> None:
-        super().__init__(*args, **kwargs)
-
     def __new__(
-        cls, value=None, _sn_gen=_serial_number_generator(), _prefix=_unique_id()
-    ):
+        cls,
+        value: Optional[str] = None,
+        _sn_gen: Callable[[], str] = _serial_number_generator(),
+        _prefix: str = _unique_id(),
+    ) -> "BNode":
         """
         # only store implementations should pass in a value
         """
@@ -423,7 +420,7 @@ class BNode(Identifier):
             pass  # assert is_ncname(str(value)), "BNode identifiers
             # must be valid NCNames" _:[A-Za-z][A-Za-z0-9]*
             # http://www.w3.org/TR/2004/REC-rdf-testcases-20040210/#nodeID
-        return Identifier.__new__(cls, value)
+        return Identifier.__new__(cls, value)  # type: ignore[return-value]
 
     def toPython(self) -> str:
         return str(self)
@@ -545,10 +542,6 @@ class Literal(Identifier):
     _value: Any
 
     __slots__ = ("_language", "_datatype", "_value")
-
-    def __init__(self, *args, **kwargs) -> None:
-        super().__init__(*args, **kwargs)
-
     def __new__(
         cls,
         lexical_or_value: Any,
diff --git a/test/test_literal.py b/test/test_literal.py
index ae77825c..3fa29aa0 100644
--- a/test/test_literal.py
+++ b/test/test_literal.py
@@ -74,7 +74,7 @@ class TestNewPT:
         self,
         lang: Any,
         exception_type: Type[Exception],
-    ):
+    ) -> None:
         """
         Construction of Literal fails if the language tag is invalid.
         """