diff options
| author | Bar Shaul <88437685+barshaul@users.noreply.github.com> | 2022-11-10 13:16:49 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-11-10 13:16:49 +0200 |
| commit | 67214cc3eaa7890c87e45550b8320779f954094b (patch) | |
| tree | 3bca8b8913224255bdf72de79265ca0441cecb1c /redis/asyncio/connection.py | |
| parent | bb06ccd52924800ac501d17c8a42038c8e5c5770 (diff) | |
| download | redis-py-67214cc3eaa7890c87e45550b8320779f954094b.tar.gz | |
Failover handling improvements for RedisCluster and Async RedisCluster (#2377)
* Cluster&AsyncCluster: Removed handling of timeouts/connection errors within the cluster loop, fixed "cannot pickle '_thread.lock' object" bug, added client's side failover handling improvements
* Fixed linters
* Type fixes
* Added to CHANGES
* Added getter and setter for the client's retry object and added more tests
* Fixed linters
* Fixed test
* Fixed test_client_kill test
* Changed get_default_backoff to default_backoff, removed retry_on_error and connection_error_retry_attempts from RedisCluster, default retry changed to no retries
* Fixing linters
* Reverting deletion of connection_error_retry_attempts to maintain backward compatibility
* Updating retry object for existing and new connections
* Changed the default value of reinitialize_steps from 10 to 5
* fix review comments
Co-authored-by: Chayim <chayim@users.noreply.github.com>
Co-authored-by: dvora-h <dvora.heller@redis.com>
Co-authored-by: dvora-h <67596500+dvora-h@users.noreply.github.com>
Diffstat (limited to 'redis/asyncio/connection.py')
| -rw-r--r-- | redis/asyncio/connection.py | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/redis/asyncio/connection.py b/redis/asyncio/connection.py index df066c4..4f19153 100644 --- a/redis/asyncio/connection.py +++ b/redis/asyncio/connection.py @@ -497,7 +497,7 @@ class Connection: retry_on_error.append(socket.timeout) retry_on_error.append(asyncio.TimeoutError) self.retry_on_error = retry_on_error - if retry_on_error: + if retry or retry_on_error: if not retry: self.retry = Retry(NoBackoff(), 1) else: @@ -1445,6 +1445,12 @@ class ConnectionPool: if exc: raise exc + def set_retry(self, retry: "Retry") -> None: + for conn in self._available_connections: + conn.retry = retry + for conn in self._in_use_connections: + conn.retry = retry + class BlockingConnectionPool(ConnectionPool): """ |