summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKeewis <keewis@posteo.de>2020-08-12 19:48:07 +0200
committerKeewis <keewis@posteo.de>2020-08-12 19:48:07 +0200
commit1c388241b463c70f3191aacad2b0867c53245f49 (patch)
treefbe9cd4b8d9ecebdffc6109cffb37e8a24aba0b1
parentbe65bded764597476474bdeb7862707ae965ee5b (diff)
downloadsphinx-git-1c388241b463c70f3191aacad2b0867c53245f49.tar.gz
default to False and update the tests
-rw-r--r--sphinx/ext/napoleon/__init__.py6
-rw-r--r--tests/test_ext_napoleon_docstring.py60
2 files changed, 34 insertions, 32 deletions
diff --git a/sphinx/ext/napoleon/__init__.py b/sphinx/ext/napoleon/__init__.py
index 793384dd2..e62ef7152 100644
--- a/sphinx/ext/napoleon/__init__.py
+++ b/sphinx/ext/napoleon/__init__.py
@@ -41,7 +41,7 @@ class Config:
napoleon_use_param = True
napoleon_use_rtype = True
napoleon_use_keyword = True
- napoleon_preprocess_types = True
+ napoleon_preprocess_types = False
napoleon_type_aliases = None
napoleon_custom_sections = None
@@ -238,7 +238,7 @@ class Config:
:returns: *bool* -- True if successful, False otherwise
- napoleon_preprocess_types : :obj:`bool` (Defaults to True)
+ napoleon_preprocess_types : :obj:`bool` (Defaults to False)
Enable the type preprocessor for numpy style docstrings.
napoleon_type_aliases : :obj:`dict` (Defaults to None)
@@ -272,7 +272,7 @@ class Config:
'napoleon_use_param': (True, 'env'),
'napoleon_use_rtype': (True, 'env'),
'napoleon_use_keyword': (True, 'env'),
- 'napoleon_preprocess_types': (True, 'env'),
+ 'napoleon_preprocess_types': (False, 'env'),
'napoleon_type_aliases': (None, 'env'),
'napoleon_custom_sections': (None, 'env')
}
diff --git a/tests/test_ext_napoleon_docstring.py b/tests/test_ext_napoleon_docstring.py
index 06a4a0c1a..bbc075edd 100644
--- a/tests/test_ext_napoleon_docstring.py
+++ b/tests/test_ext_napoleon_docstring.py
@@ -66,19 +66,19 @@ Sample namedtuple subclass
Quick description of attr1
- :type: :class:`Arbitrary type`
+ :type: Arbitrary type
.. attribute:: attr2
Quick description of attr2
- :type: :class:`Another arbitrary type`
+ :type: Another arbitrary type
.. attribute:: attr3
Adds a newline after the type
- :type: :class:`Type`
+ :type: Type
"""
self.assertEqual(expected, actual)
@@ -1311,7 +1311,8 @@ class NumpyDocstringTest(BaseDocstringTest):
config = Config(
napoleon_use_param=False,
napoleon_use_rtype=False,
- napoleon_use_keyword=False)
+ napoleon_use_keyword=False,
+ napoleon_preprocess_types=True)
for docstring, expected in self.docstrings:
actual = str(NumpyDocstring(dedent(docstring), config))
expected = dedent(expected)
@@ -1373,7 +1374,7 @@ x1, x2 : array_like
config = Config(napoleon_use_param=False)
actual = str(NumpyDocstring(docstring, config))
expected = """\
-:Parameters: **x1, x2** (:class:`array_like`) -- Input arrays, description of ``x1``, ``x2``.
+:Parameters: **x1, x2** (*array_like*) -- Input arrays, description of ``x1``, ``x2``.
"""
self.assertEqual(expected, actual)
@@ -1381,9 +1382,9 @@ x1, x2 : array_like
actual = str(NumpyDocstring(dedent(docstring), config))
expected = """\
:param x1: Input arrays, description of ``x1``, ``x2``.
-:type x1: :class:`array_like`
+:type x1: array_like
:param x2: Input arrays, description of ``x1``, ``x2``.
-:type x2: :class:`array_like`
+:type x2: array_like
"""
self.assertEqual(expected, actual)
@@ -1398,7 +1399,7 @@ param1 : MyClass instance
config = Config(napoleon_use_param=False)
actual = str(NumpyDocstring(docstring, config))
expected = """\
-:Parameters: **param1** (:class:`MyClass instance`)
+:Parameters: **param1** (*MyClass instance*)
"""
self.assertEqual(expected, actual)
@@ -1406,7 +1407,7 @@ param1 : MyClass instance
actual = str(NumpyDocstring(dedent(docstring), config))
expected = """\
:param param1:
-:type param1: :class:`MyClass instance`
+:type param1: MyClass instance
"""
self.assertEqual(expected, actual)
@@ -1495,7 +1496,7 @@ arg_ : type
expected = """
:ivar arg_: some description
-:vartype arg_: :class:`type`
+:vartype arg_: type
"""
config = Config(napoleon_use_ivar=True)
@@ -1515,7 +1516,7 @@ arg_ : type
expected = """
:ivar arg\\_: some description
-:vartype arg\\_: :class:`type`
+:vartype arg\\_: type
"""
config = Config(napoleon_use_ivar=True)
@@ -1883,59 +1884,59 @@ definition_after_normal_text : int
expected = """One line summary.
:param no_list:
-:type no_list: :class:`int`
+:type no_list: int
:param one_bullet_empty:
*
-:type one_bullet_empty: :class:`int`
+:type one_bullet_empty: int
:param one_bullet_single_line:
- first line
-:type one_bullet_single_line: :class:`int`
+:type one_bullet_single_line: int
:param one_bullet_two_lines:
+ first line
continued
-:type one_bullet_two_lines: :class:`int`
+:type one_bullet_two_lines: int
:param two_bullets_single_line:
- first line
- second line
-:type two_bullets_single_line: :class:`int`
+:type two_bullets_single_line: int
:param two_bullets_two_lines:
* first line
continued
* second line
continued
-:type two_bullets_two_lines: :class:`int`
+:type two_bullets_two_lines: int
:param one_enumeration_single_line:
1. first line
-:type one_enumeration_single_line: :class:`int`
+:type one_enumeration_single_line: int
:param one_enumeration_two_lines:
1) first line
continued
-:type one_enumeration_two_lines: :class:`int`
+:type one_enumeration_two_lines: int
:param two_enumerations_one_line:
(iii) first line
(iv) second line
-:type two_enumerations_one_line: :class:`int`
+:type two_enumerations_one_line: int
:param two_enumerations_two_lines:
a. first line
continued
b. second line
continued
-:type two_enumerations_two_lines: :class:`int`
+:type two_enumerations_two_lines: int
:param one_definition_one_line:
item 1
first line
-:type one_definition_one_line: :class:`int`
+:type one_definition_one_line: int
:param one_definition_two_lines:
item 1
first line
continued
-:type one_definition_two_lines: :class:`int`
+:type one_definition_two_lines: int
:param two_definitions_one_line:
item 1
first line
item 2
second line
-:type two_definitions_one_line: :class:`int`
+:type two_definitions_one_line: int
:param two_definitions_two_lines:
item 1
first line
@@ -1943,14 +1944,14 @@ definition_after_normal_text : int
item 2
second line
continued
-:type two_definitions_two_lines: :class:`int`
+:type two_definitions_two_lines: int
:param one_definition_blank_line:
item 1
first line
extra first line
-:type one_definition_blank_line: :class:`int`
+:type one_definition_blank_line: int
:param two_definitions_blank_lines:
item 1
@@ -1963,12 +1964,12 @@ definition_after_normal_text : int
second line
extra second line
-:type two_definitions_blank_lines: :class:`int`
+:type two_definitions_blank_lines: int
:param definition_after_normal_text: text line
item 1
first line
-:type definition_after_normal_text: :class:`int`
+:type definition_after_normal_text: int
"""
config = Config(napoleon_use_param=True)
actual = str(NumpyDocstring(docstring, config))
@@ -2062,7 +2063,7 @@ definition_after_normal_text : int
item 1
first line
"""
- config = Config(napoleon_use_param=False)
+ config = Config(napoleon_use_param=False, napoleon_preprocess_types=True)
actual = str(NumpyDocstring(docstring, config))
self.assertEqual(expected, actual)
@@ -2243,6 +2244,7 @@ definition_after_normal_text : int
config = Config(
napoleon_use_param=True,
napoleon_use_rtype=True,
+ napoleon_preprocess_types=True,
napoleon_type_aliases=translations,
)
actual = str(NumpyDocstring(docstring, config))