From 71dec3b38e8231125bcc25b3bf6e484df921194f Mon Sep 17 00:00:00 2001
From: Martin Packman <martin@zegami.com>
Date: Mon, 4 Mar 2019 15:58:12 +0000
Subject: Fix UnboundLocalError when building changes

Split testing of changes builder to its own test file and root.
Improve coverage a little, and add case that fails if a module
directive is included in the rst source.

Correctly handle changesets with a module declared.

Fixes https://github.com/sphinx-doc/sphinx/issues/6134
---
 sphinx/builders/changes.py | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

(limited to 'sphinx/builders/changes.py')

diff --git a/sphinx/builders/changes.py b/sphinx/builders/changes.py
index 308ae9656..aa5fea5a5 100644
--- a/sphinx/builders/changes.py
+++ b/sphinx/builders/changes.py
@@ -85,8 +85,7 @@ class ChangesBuilder(Builder):
                     entry = '<b>%s</b>: <i>%s</i>.' % (descname, ttext)
                 apichanges.append((entry, changeset.docname, changeset.lineno))
             elif descname or changeset.module:
-                if not changeset.module:
-                    module = _('Builtins')
+                module = changeset.module or _('Builtins')
                 if not descname:
                     descname = _('Module level')
                 if context:
-- 
cgit v1.2.1