From 8bb73c9fd3555deb83f01e1d18fa10c563202f78 Mon Sep 17 00:00:00 2001 From: Jon Dufresne Date: Tue, 11 Dec 2018 06:46:04 -0800 Subject: Simplify open() call by removing default mode The open() function opens files in read-only text mode by default. Drop the mode argument to be slightly simpler and more idiomatic. https://docs.python.org/3/library/functions.html#open > The default mode is 'r' (open for reading text, synonym of 'rt'). --- sphinx/directives/code.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'sphinx/directives/code.py') diff --git a/sphinx/directives/code.py b/sphinx/directives/code.py index b513a37e0..574e06e5e 100644 --- a/sphinx/directives/code.py +++ b/sphinx/directives/code.py @@ -216,7 +216,7 @@ class LiteralIncludeReader: def read_file(self, filename, location=None): # type: (unicode, Any) -> List[unicode] try: - with open(filename, 'r', # type: ignore + with open(filename, # type: ignore encoding=self.encoding, errors='strict') as f: text = f.read() # type: unicode if 'tab-width' in self.options: -- cgit v1.2.1