From 8bb73c9fd3555deb83f01e1d18fa10c563202f78 Mon Sep 17 00:00:00 2001 From: Jon Dufresne Date: Tue, 11 Dec 2018 06:46:04 -0800 Subject: Simplify open() call by removing default mode The open() function opens files in read-only text mode by default. Drop the mode argument to be slightly simpler and more idiomatic. https://docs.python.org/3/library/functions.html#open > The default mode is 'r' (open for reading text, synonym of 'rt'). --- sphinx/ext/coverage.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'sphinx/ext/coverage.py') diff --git a/sphinx/ext/coverage.py b/sphinx/ext/coverage.py index 3045c8c87..fa9fac03b 100644 --- a/sphinx/ext/coverage.py +++ b/sphinx/ext/coverage.py @@ -102,7 +102,7 @@ class CoverageBuilder(Builder): c_objects = self.env.domaindata['c']['objects'] for filename in self.c_sourcefiles: undoc = set() # type: Set[Tuple[unicode, unicode]] - with open(filename, 'r') as f: + with open(filename) as f: for line in f: for key, regex in self.c_regexes: match = regex.match(line) -- cgit v1.2.1