delta/python-packages/sqlalchemy.git/lib/sqlalchemy/connectors, branch workflow_test_foo github.com: zzzeek/sqlalchemy.git Remove comment code lines 2020-07-25T20:33:25+00:00 j00356287 jiajunsu@huawei.com 2020-07-25T20:33:25+00:00 448c1aef216e274d21deb03fdcafad1289f7951b PyODBCConnector.initialize just super from Connector, no need to redeclare, so I guess that's why they are commented before. <!-- Provide a general summary of your proposed changes in the Title field above --> ### Description <!-- Describe your changes in detail --> Remove the useless comment code lines. ### Checklist <!-- go over following points. check them with an `x` if they do apply, (they turn into clickable checkboxes once the PR is submitted, so no need to do everything at once) --> This pull request is: - [x] A documentation / typographical error fix - Good to go, no issue or tests are needed - [ ] A short code fix - please include the issue number, and create an issue if none exists, which must include a complete example of the issue. one line code fixes without an issue and demonstration will not be accepted. - Please include: `Fixes: #<issue number>` in the commit message - please include tests. one line code fixes without tests will not be accepted. - [ ] A new feature implementation - please include the issue number, and create an issue if none exists, which must include a complete example of how the feature would look. - Please include: `Fixes: #<issue number>` in the commit message - please include tests. **Have a nice day!** Closes: #5475 Pull-request: https://github.com/sqlalchemy/sqlalchemy/pull/5475 Pull-request-sha: 23176a7f0316d74407492c2bb299c88924ed0868 Change-Id: If94bb6275c30015e3aaa1519471b7d9bcda18bf8 
PyODBCConnector.initialize just super from Connector, no need to redeclare, so I guess that's why they are commented before.

<!-- Provide a general summary of your proposed changes in the Title field above -->

### Description
<!-- Describe your changes in detail -->

Remove the useless comment code lines.

### Checklist
<!-- go over following points. check them with an `x` if they do apply, (they turn into clickable checkboxes once the PR is submitted, so no need to do everything at once)

-->

This pull request is:

- [x] A documentation / typographical error fix
	- Good to go, no issue or tests are needed
- [ ] A short code fix
	- please include the issue number, and create an issue if none exists, which
	  must include a complete example of the issue.  one line code fixes without an
	  issue and demonstration will not be accepted.
	- Please include: `Fixes: #<issue number>` in the commit message
	- please include tests.   one line code fixes without tests will not be accepted.
- [ ] A new feature implementation
	- please include the issue number, and create an issue if none exists, which must
	  include a complete example of how the feature would look.
	- Please include: `Fixes: #<issue number>` in the commit message
	- please include tests.

**Have a nice day!**

Closes: #5475
Pull-request: https://github.com/sqlalchemy/sqlalchemy/pull/5475
Pull-request-sha: 23176a7f0316d74407492c2bb299c88924ed0868

Change-Id: If94bb6275c30015e3aaa1519471b7d9bcda18bf8
Fix connection string escaping for mssql+pyodbc 2020-06-04T18:38:13+00:00 Gord Thompson gord@gordthompson.com 2020-06-04T18:38:13+00:00 14bc09203a8b5b2bc001f764ad7cce6a184975cc Fixes: #5373 Change-Id: Ia41e8f1ef8644c54d23ebfdf3f909c785adf0fb0 
Fixes: #5373
Change-Id: Ia41e8f1ef8644c54d23ebfdf3f909c785adf0fb0
Don't emit pyodbc "no driver" warning for empty URL 2020-05-22T17:15:30+00:00 Mike Bayer mike_mp@zzzcomputing.com 2020-05-22T17:14:58+00:00 29534cf13939c7f7fe59399f12d50df2fcab7a38 Fixed an issue in the pyodbc connector such that a warning about pyodbc "drivername" would be emitted when using a totally empty URL. Empty URLs are normal when producing a non-connected dialect object or when using the "creator" argument to create_engine(). The warning now only emits if the driver name is missing but other parameters are still present. Fixes: #5346 Change-Id: I0ee6f5fd5af7faca63bf0d7034410942f40834a8 
Fixed an issue in the pyodbc connector such that a warning about pyodbc
"drivername" would be emitted when using a totally empty URL.  Empty URLs
are normal when producing a non-connected dialect object or when using the
"creator" argument to create_engine(). The warning now only emits if the
driver name is missing but other parameters are still present.

Fixes: #5346
Change-Id: I0ee6f5fd5af7faca63bf0d7034410942f40834a8
Move supports_sane_rowcount_returning = False to dialect level 2020-05-11T20:44:37+00:00 Gord Thompson gord@gordthompson.com 2020-05-11T20:44:37+00:00 cc97dade0de008ce923dbb94db21a8e1ccb5bb22 Fixes: #5321 Change-Id: Id83e98e9013818424c133297a850746302633158 
Fixes: #5321
Change-Id: Id83e98e9013818424c133297a850746302633158
Deprecate unsupported dialects and dbapi 2020-04-29T17:50:44+00:00 Federico Caselli cfederico87@gmail.com 2020-04-18T18:58:41+00:00 18ce4f9937c2d6753acbb054b4990c7da298a5d7 - Deprecate dialects firebird and sybase. - Deprecate DBAPI - mxODBC for mssql - oursql for mysql - pygresql and py-postgresql for postgresql - Removed adodbapi DBAPI for mssql Fixes: #5189 Change-Id: Id9025f4f4de7e97d65aacd0eb4b0c21beb9a67b5 
- Deprecate dialects firebird and sybase.

- Deprecate DBAPI

  - mxODBC for mssql

  - oursql for mysql

  - pygresql and py-postgresql for postgresql

- Removed adodbapi DBAPI for mssql

Fixes: #5189
Change-Id: Id9025f4f4de7e97d65aacd0eb4b0c21beb9a67b5
Remove jython code, remove all jython / pypy symbols 2020-01-17T22:44:57+00:00 Mike Bayer mike_mp@zzzcomputing.com 2020-01-17T22:31:41+00:00 9e31fc74089cf565df5f275d22eb8ae5414d6e45 Removed all dialect code related to support for Jython and zxJDBC. Jython has not been supported by SQLAlchemy for many years and it is not expected that the current zxJDBC code is at all functional; for the moment it just takes up space and adds confusion by showing up in documentation. At the moment, it appears that Jython has achieved Python 2.7 support in its releases but not Python 3. If Jython were to be supported again, the form it should take is against the Python 3 version of Jython, and the various zxJDBC stubs for various backends should be implemented as a third party dialect. Additionally modernized logic that distinguishes between "cpython" and "pypy" to instead look at platform.python_distribution() which reliably tells us if we are cPython or not; all booleans which previously checked for pypy and sometimes jython are now converted to be "not cpython", this impacts the test suite for tests that are cPython centric. Fixes: #5094 Change-Id: I226cb55827f997daf6b4f4a755c18e7f4eb8d9ad 
Removed all dialect code related to support for Jython and zxJDBC. Jython
has not been supported by SQLAlchemy for many years and it is not expected
that the current zxJDBC code is at all functional; for the moment it just
takes up space and adds confusion by showing up in documentation. At the
moment, it appears that Jython has achieved Python 2.7 support in its
releases but not Python 3.   If Jython were to be supported again, the form
it should take is against the Python 3 version of Jython, and the various
zxJDBC stubs for various backends should be implemented as a third party
dialect.

Additionally modernized logic that distinguishes between "cpython"
and "pypy" to instead look at platform.python_distribution() which
reliably tells us if we are cPython or not; all booleans which
previously checked for pypy and sometimes jython are now converted
to be "not cpython", this impacts the test suite for tests that are
cPython centric.

Fixes: #5094
Change-Id: I226cb55827f997daf6b4f4a755c18e7f4eb8d9ad
happy new year 2020-01-01T17:09:47+00:00 Mike Bayer mike_mp@zzzcomputing.com 2020-01-01T17:09:47+00:00 5881fd274015af3de37f2ff0f91ff6a7c61c1540 Change-Id: I08440dc25e40ea1ccea1778f6ee9e28a00808235 
Change-Id: I08440dc25e40ea1ccea1778f6ee9e28a00808235
happy new year 2019-01-11T15:06:10+00:00 Mike Bayer mike_mp@zzzcomputing.com 2019-01-11T15:06:10+00:00 6f270fb0e344016ce526e0a1ecb3e3de9ffd1e3b Change-Id: I6a71f4924d046cf306961c58dffccf21e9c03911 
Change-Id: I6a71f4924d046cf306961c58dffccf21e9c03911
Post black reformatting 2019-01-06T23:23:11+00:00 Mike Bayer mike_mp@zzzcomputing.com 2019-01-06T06:19:47+00:00 1e278de4cc9a4181e0747640a960e80efcea1ca9 Applied on top of a pure run of black -l 79 in I7eda77fed3d8e73df84b3651fd6cfcfe858d4dc9, this set of changes resolves all remaining flake8 conditions for those codes we have enabled in setup.cfg. Included are resolutions for all remaining flake8 issues including shadowed builtins, long lines, import order, unused imports, duplicate imports, and docstring issues. Change-Id: I4f72d3ba1380dd601610ff80b8fb06a2aff8b0fe 
Applied on top of a pure run of black -l 79 in
I7eda77fed3d8e73df84b3651fd6cfcfe858d4dc9,  this set of changes
resolves all remaining flake8 conditions for those codes
we have enabled in setup.cfg.

Included are resolutions for all remaining flake8 issues
including shadowed builtins, long lines, import order, unused
imports, duplicate imports, and docstring issues.

Change-Id: I4f72d3ba1380dd601610ff80b8fb06a2aff8b0fe
Run black -l 79 against all source files 2019-01-06T17:34:50+00:00 Mike Bayer mike_mp@zzzcomputing.com 2019-01-06T06:14:26+00:00 1e1a38e7801f410f244e4bbb44ec795ae152e04e This is a straight reformat run using black as is, with no edits applied at all. The black run will format code consistently, however in some cases that are prevalent in SQLAlchemy code it produces too-long lines. The too-long lines will be resolved in the following commit that will resolve all remaining flake8 issues including shadowed builtins, long lines, import order, unused imports, duplicate imports, and docstring issues. Change-Id: I7eda77fed3d8e73df84b3651fd6cfcfe858d4dc9 
This is a straight reformat run using black as is, with no edits
applied at all.

The black run will format code consistently, however in
some cases that are prevalent in SQLAlchemy code it produces
too-long lines.   The too-long lines will be resolved in the
following commit that will resolve all remaining flake8 issues
including shadowed builtins, long lines, import order, unused
imports, duplicate imports, and docstring issues.

Change-Id: I7eda77fed3d8e73df84b3651fd6cfcfe858d4dc9