diff options
| author | Mike Bayer <mike_mp@zzzcomputing.com> | 2010-03-19 17:37:43 -0400 |
|---|---|---|
| committer | Mike Bayer <mike_mp@zzzcomputing.com> | 2010-03-19 17:37:43 -0400 |
| commit | b31a17c521ec1160a653774e2a4b99b01d27a644 (patch) | |
| tree | cb0e5fbca3dbe0fb319c163f83c30d0dd118c108 /lib/sqlalchemy/dialects/mysql | |
| parent | 0f55ef3beadc6d149fcc2273cb16531fc0a02251 (diff) | |
| download | sqlalchemy-b31a17c521ec1160a653774e2a4b99b01d27a644.tar.gz | |
removed all dialect table_names() methods and standardized
on get_table_names(). [ticket:1739]
Diffstat (limited to 'lib/sqlalchemy/dialects/mysql')
| -rw-r--r-- | lib/sqlalchemy/dialects/mysql/base.py | 12 | ||||
| -rw-r--r-- | lib/sqlalchemy/dialects/mysql/oursql.py | 4 |
2 files changed, 6 insertions, 10 deletions
diff --git a/lib/sqlalchemy/dialects/mysql/base.py b/lib/sqlalchemy/dialects/mysql/base.py index 2311b06df..df4a666fb 100644 --- a/lib/sqlalchemy/dialects/mysql/base.py +++ b/lib/sqlalchemy/dialects/mysql/base.py @@ -1766,24 +1766,20 @@ class MySQLDialect(default.DefaultDialect): @reflection.cache def get_table_names(self, connection, schema=None, **kw): + """Return a Unicode SHOW TABLES from a given schema.""" if schema is not None: current_schema = schema else: current_schema = self.default_schema_name - table_names = self.table_names(connection, current_schema) - return table_names - - def table_names(self, connection, schema): - """Return a Unicode SHOW TABLES from a given schema.""" charset = self._connection_charset if self.server_version_info < (5, 0, 2): rp = connection.execute("SHOW TABLES FROM %s" % - self.identifier_preparer.quote_identifier(schema)) + self.identifier_preparer.quote_identifier(current_schema)) return [row[0] for row in self._compat_fetchall(rp, charset=charset)] else: rp = connection.execute("SHOW FULL TABLES FROM %s" % - self.identifier_preparer.quote_identifier(schema)) + self.identifier_preparer.quote_identifier(current_schema)) return [row[0] for row in self._compat_fetchall(rp, charset=charset)\ if row[1] == 'BASE TABLE'] @@ -1796,7 +1792,7 @@ class MySQLDialect(default.DefaultDialect): if schema is None: schema = self.default_schema_name if self.server_version_info < (5, 0, 2): - return self.table_names(connection, schema) + return self.get_table_names(connection, schema) charset = self._connection_charset rp = connection.execute("SHOW FULL TABLES FROM %s" % self.identifier_preparer.quote_identifier(schema)) diff --git a/lib/sqlalchemy/dialects/mysql/oursql.py b/lib/sqlalchemy/dialects/mysql/oursql.py index f26bc4da2..9e38993f2 100644 --- a/lib/sqlalchemy/dialects/mysql/oursql.py +++ b/lib/sqlalchemy/dialects/mysql/oursql.py @@ -151,8 +151,8 @@ class MySQLDialect_oursql(MySQLDialect): **kw ) - def table_names(self, connection, schema): - return MySQLDialect.table_names(self, + def get_table_names(self, connection, schema=None, **kw): + return MySQLDialect.get_table_names(self, connection.connect().\ execution_options(_oursql_plain_query=True), schema |
