summaryrefslogtreecommitdiff
path: root/lib/sqlalchemy/ext/mutable.py
diff options
context:
space:
mode:
authorMike Bayer <mike_mp@zzzcomputing.com>2011-05-14 10:23:12 -0400
committerMike Bayer <mike_mp@zzzcomputing.com>2011-05-14 10:23:12 -0400
commit501b8aec1b2ccd3cb652cd6f7f8d00047ef5e84c (patch)
treed7b6ff0b968e069cb770140e031e5f3bd0a5ed3b /lib/sqlalchemy/ext/mutable.py
parent9826ba73a6a614a92be7104474428dde40c2d773 (diff)
downloadsqlalchemy-501b8aec1b2ccd3cb652cd6f7f8d00047ef5e84c.tar.gz
- Fixed bugs in sqlalchemy.ext.mutable extension where
`None` was not appropriately handled, replacement events were not appropriately handled. [ticket:2143]
Diffstat (limited to 'lib/sqlalchemy/ext/mutable.py')
-rw-r--r--lib/sqlalchemy/ext/mutable.py10
1 files changed, 5 insertions, 5 deletions
diff --git a/lib/sqlalchemy/ext/mutable.py b/lib/sqlalchemy/ext/mutable.py
index d14cfe3c0..078f9f3a2 100644
--- a/lib/sqlalchemy/ext/mutable.py
+++ b/lib/sqlalchemy/ext/mutable.py
@@ -378,12 +378,12 @@ class MutableBase(object):
outgoing.
"""
-
if not isinstance(value, cls):
- value = cls.coerce(key, value)
- value._parents[target.obj()] = key
+ value = cls.coerce(key, value)
+ if value is not None:
+ value._parents[target.obj()] = key
if isinstance(oldvalue, cls):
- oldvalue._parents.pop(state.obj(), None)
+ oldvalue._parents.pop(target.obj(), None)
return value
def pickle(state, state_dict):
@@ -426,7 +426,7 @@ class Mutable(MutableBase):
"""
if value is None:
return None
- raise ValueError("Attribute '%s' accepts objects of type %s" % (key, cls))
+ raise ValueError("Attribute '%s' does not accept objects of type %s" % (key, type(value)))
@classmethod
def associate_with_attribute(cls, attribute):