summaryrefslogtreecommitdiff
path: root/lib/sqlalchemy/sql/selectable.py
diff options
context:
space:
mode:
authorMike Bayer <mike_mp@zzzcomputing.com>2013-10-08 20:06:58 -0400
committerMike Bayer <mike_mp@zzzcomputing.com>2013-10-08 20:06:58 -0400
commite74627f827542044c1d2087be95e41d4b1b46f24 (patch)
tree271f25fc6cc032008f2a61609b35a2f5e01dfa3e /lib/sqlalchemy/sql/selectable.py
parent9df4651fba6d1cd3d2b490f58263cc45a81788f4 (diff)
downloadsqlalchemy-e74627f827542044c1d2087be95e41d4b1b46f24.tar.gz
A :func:`.select` that is made to refer to itself in its FROM clause,
typically via in-place mutation, will raise an informative error message rather than causing a recursion overflow. [ticket:2815]
Diffstat (limited to 'lib/sqlalchemy/sql/selectable.py')
-rw-r--r--lib/sqlalchemy/sql/selectable.py3
1 files changed, 3 insertions, 0 deletions
diff --git a/lib/sqlalchemy/sql/selectable.py b/lib/sqlalchemy/sql/selectable.py
index e06262c6d..43d5a084c 100644
--- a/lib/sqlalchemy/sql/selectable.py
+++ b/lib/sqlalchemy/sql/selectable.py
@@ -1936,6 +1936,9 @@ class Select(HasPrefixes, SelectBase):
def add(items):
for item in items:
+ if item is self:
+ raise exc.InvalidRequestError(
+ "select() construct refers to itself as a FROM")
if translate and item in translate:
item = translate[item]
if not seen.intersection(item._cloned_set):