summaryrefslogtreecommitdiff
path: root/test/base
diff options
context:
space:
mode:
authorMike Bayer <mike_mp@zzzcomputing.com>2019-05-30 11:31:03 -0400
committerMike Bayer <mike_mp@zzzcomputing.com>2019-06-20 13:50:41 -0400
commit190e0139e834e4271268652e058c280787ae69eb (patch)
tree21e93907a58cd2f390f687ddc5e0c1da1eb25454 /test/base
parentff8e7732b9f656f8cea05544660c18d57dd37864 (diff)
downloadsqlalchemy-190e0139e834e4271268652e058c280787ae69eb.tar.gz
Enable F841
This is a very useful assertion which prevents unused variables from being set up allows code to be more readable and sometimes even more efficient. test suites seem to be where the most problems are and there do not seem to be documentation examples that are using this, or at least the linter is not taking effect within rst blocks. Change-Id: I2b3341d8dd14da34879d8425838e66a4b9f8e27d
Diffstat (limited to 'test/base')
-rw-r--r--test/base/test_inspect.py2
-rw-r--r--test/base/test_utils.py4
2 files changed, 3 insertions, 3 deletions
diff --git a/test/base/test_inspect.py b/test/base/test_inspect.py
index 6c2cd0c08..15b98c848 100644
--- a/test/base/test_inspect.py
+++ b/test/base/test_inspect.py
@@ -71,6 +71,6 @@ class TestInspection(fixtures.TestBase):
def insp_somesubfoo(subject):
return 2
- somefoo = SomeFoo()
+ SomeFoo()
eq_(inspect(SomeFoo()), 1)
eq_(inspect(SomeSubFoo()), 2)
diff --git a/test/base/test_utils.py b/test/base/test_utils.py
index e96162703..fea34cf8d 100644
--- a/test/base/test_utils.py
+++ b/test/base/test_utils.py
@@ -763,7 +763,7 @@ class LRUTest(fixtures.TestBase):
for id_ in (25, 24, 23, 14, 12, 19, 18, 17, 16, 15):
assert id_ in lru
- i1 = lru[25]
+ lru[25]
i2 = item(25)
lru[25] = i2
assert 25 in lru
@@ -1839,7 +1839,7 @@ class SymbolTest(fixtures.TestBase):
# default
s = util.pickle.dumps(sym1)
- sym3 = util.pickle.loads(s)
+ util.pickle.loads(s)
for protocol in 0, 1, 2:
print(protocol)