- [bug] Fixed bug in over() construct whereby

    passing an empty list for either partition_by
    or order_by, as opposed to None, would fail
    to generate correctly.
    Courtesy Gunnlaugur Por Briem.
    [ticket:2574]

1 files changed, 28 insertions, 0 deletions

diff --git a/test/sql/test_compiler.py b/test/sql/test_compiler.py
index 3c6e687ca..b09ae1ab0 100644
--- a/test/sql/test_compiler.py
+++ b/test/sql/test_compiler.py
@@ -2258,6 +2258,10 @@ class SelectTest(fixtures.TestBase, AssertsCompiledSQL):
 
     def test_over(self):
         self.assert_compile(
+            func.row_number().over(),
+            "row_number() OVER ()"
+        )
+        self.assert_compile(
             func.row_number().over(
                 order_by=[table1.c.name, table1.c.description]
             ),
@@ -2297,6 +2301,30 @@ class SelectTest(fixtures.TestBase, AssertsCompiledSQL):
         )
 
         self.assert_compile(
+            func.row_number().over(
+                partition_by=[],
+                order_by=[table1.c.name, table1.c.description]
+            ),
+            "row_number() OVER (ORDER BY mytable.name, mytable.description)"
+        )
+
+        self.assert_compile(
+            func.row_number().over(
+                partition_by=[table1.c.name, table1.c.description],
+                order_by=[]
+            ),
+            "row_number() OVER (PARTITION BY mytable.name, "
+            "mytable.description)"
+        )
+
+        self.assert_compile(
+            func.row_number().over(
+                partition_by=[],
+                order_by=[]
+            ),
+            "row_number() OVER ()"
+        )
+        self.assert_compile(
             select([func.row_number().over(
                 order_by=table1.c.description
             ).label('foo')]),