summaryrefslogtreecommitdiff
path: root/lib/sqlalchemy
diff options
context:
space:
mode:
Diffstat (limited to 'lib/sqlalchemy')
-rw-r--r--lib/sqlalchemy/databases/postgres.py15
-rw-r--r--lib/sqlalchemy/sql/expression.py2
2 files changed, 8 insertions, 9 deletions
diff --git a/lib/sqlalchemy/databases/postgres.py b/lib/sqlalchemy/databases/postgres.py
index 2a4d230cd..e2876f1f8 100644
--- a/lib/sqlalchemy/databases/postgres.py
+++ b/lib/sqlalchemy/databases/postgres.py
@@ -567,15 +567,14 @@ class PGCompiler(compiler.DefaultCompiler):
def get_select_precolumns(self, select):
if select._distinct:
- if type(select._distinct) == bool:
+ if isinstance(select._distinct, bool):
return "DISTINCT "
- if type(select._distinct) == list:
- dist_set = "DISTINCT ON ("
- for col in select._distinct:
- dist_set += self.strings[col] + ", "
- dist_set = dist_set[:-2] + ") "
- return dist_set
- return "DISTINCT ON (" + str(select._distinct) + ") "
+ elif isinstance(select._distinct, (list, tuple)):
+ return "DISTINCT ON (" + ', '.join(
+ [(isinstance(col, basestring) and col or self.process(col)) for col in select._distinct]
+ )+ ") "
+ else:
+ return "DISTINCT ON (" + unicode(select._distinct) + ") "
else:
return ""
diff --git a/lib/sqlalchemy/sql/expression.py b/lib/sqlalchemy/sql/expression.py
index 41f2b741b..b31ccbe44 100644
--- a/lib/sqlalchemy/sql/expression.py
+++ b/lib/sqlalchemy/sql/expression.py
@@ -2426,7 +2426,7 @@ class Alias(FromClause):
yield c
yield self.selectable
- def _get_from_objects(self):
+ def _get_from_objects(self, **modifiers):
return [self]
bind = property(lambda s: s.selectable.bind)