From 190e0139e834e4271268652e058c280787ae69eb Mon Sep 17 00:00:00 2001 From: Mike Bayer Date: Thu, 30 May 2019 11:31:03 -0400 Subject: Enable F841 This is a very useful assertion which prevents unused variables from being set up allows code to be more readable and sometimes even more efficient. test suites seem to be where the most problems are and there do not seem to be documentation examples that are using this, or at least the linter is not taking effect within rst blocks. Change-Id: I2b3341d8dd14da34879d8425838e66a4b9f8e27d --- lib/sqlalchemy/dialects/mssql/base.py | 1 - lib/sqlalchemy/dialects/mssql/pyodbc.py | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) (limited to 'lib/sqlalchemy/dialects') diff --git a/lib/sqlalchemy/dialects/mssql/base.py b/lib/sqlalchemy/dialects/mssql/base.py index 8c3d5b3fa..99abba2c6 100644 --- a/lib/sqlalchemy/dialects/mssql/base.py +++ b/lib/sqlalchemy/dialects/mssql/base.py @@ -2674,7 +2674,6 @@ class MSDialect(default.DefaultDialect): # group rows by constraint ID, to handle multi-column FKs fkeys = [] - fknm, scols, rcols = (None, [], []) def fkey_rec(): return { diff --git a/lib/sqlalchemy/dialects/mssql/pyodbc.py b/lib/sqlalchemy/dialects/mssql/pyodbc.py index 02d70a373..2246886a3 100644 --- a/lib/sqlalchemy/dialects/mssql/pyodbc.py +++ b/lib/sqlalchemy/dialects/mssql/pyodbc.py @@ -269,7 +269,7 @@ class MSExecutionContext_pyodbc(MSExecutionContext): # without closing it (FreeTDS particularly) row = self.cursor.fetchall()[0] break - except self.dialect.dbapi.Error as e: + except self.dialect.dbapi.Error: # no way around this - nextset() consumes the previous set # so we need to just keep flipping self.cursor.nextset() -- cgit v1.2.1