From 5157e0aa542f390242dd7a6d27a6ce1663230e46 Mon Sep 17 00:00:00 2001 From: Mike Bayer Date: Tue, 15 Feb 2022 23:43:51 -0500 Subject: pep-484 for pool also extends into some areas of utils, events and others as needed. Formalizes a public hierarchy for pool API, with ManagesConnection -> PoolProxiedConnection / ConnectionPoolEntry for connectionfairy / connectionrecord, which are now what's exposed in the event API and other APIs. all public API docs moved to the new objects. Corrects the mypy plugin's check for sqlalchemy-stubs not being insatlled, which has to be imported using the dash in the name to be effective. Change-Id: I16c2cb43b2e840d28e70a015f370a768e70f3581 --- lib/sqlalchemy/engine/create.py | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) (limited to 'lib/sqlalchemy/engine/create.py') diff --git a/lib/sqlalchemy/engine/create.py b/lib/sqlalchemy/engine/create.py index a252b7cfe..ac3d6a2d8 100644 --- a/lib/sqlalchemy/engine/create.py +++ b/lib/sqlalchemy/engine/create.py @@ -12,11 +12,13 @@ from typing import Union from . import base from . import url as _url +from .interfaces import DBAPIConnection from .mock import create_mock_engine from .. import event from .. import exc -from .. import pool as poollib from .. import util +from ..pool import _AdhocProxiedConnection +from ..pool import ConnectionPoolEntry from ..sql import compiler @@ -603,10 +605,13 @@ def create_engine(url: Union[str, "_url.URL"], **kwargs: Any) -> "base.Engine": if builtin_on_connect: event.listen(pool, "connect", builtin_on_connect) - def first_connect(dbapi_connection, connection_record): + def first_connect( + dbapi_connection: DBAPIConnection, + connection_record: ConnectionPoolEntry, + ): c = base.Connection( engine, - connection=poollib._AdhocProxiedConnection( + connection=_AdhocProxiedConnection( dbapi_connection, connection_record ), _has_events=False, -- cgit v1.2.1