From 3ebc3710a72c9bb724e7074ef0409ae69cfc39fe Mon Sep 17 00:00:00 2001 From: Federico Caselli Date: Thu, 7 Jan 2021 21:22:52 +0100 Subject: ``Identity`` implies ``nullable=False``. Altered the behavior of the :class:`_schema.Identity` construct such that when applied to a :class:`_schema.Column`, it will automatically imply that the value of :paramref:`_sql.Column.nullable` should default to ``False``, in a similar manner as when the :paramref:`_sql.Column.primary_key` parameter is set to ``True``. This matches the default behavior of all supporting databases where ``IDENTITY`` implies ``NOT NULL``. The PostgreSQL backend is the only one that supports adding ``NULL`` to an ``IDENTITY`` column, which is here supported by passing a ``True`` value for the :paramref:`_sql.Column.nullable` parameter at the same time. Fixes: #5775 Change-Id: I0516d506ff327cff35cda605e8897a27440e0373 --- lib/sqlalchemy/sql/compiler.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'lib/sqlalchemy/sql/compiler.py') diff --git a/lib/sqlalchemy/sql/compiler.py b/lib/sqlalchemy/sql/compiler.py index 45cb75c25..ef7db0bbe 100644 --- a/lib/sqlalchemy/sql/compiler.py +++ b/lib/sqlalchemy/sql/compiler.py @@ -4130,7 +4130,7 @@ class DDLCompiler(Compiled): if column.identity is not None: colspec += " " + self.process(column.identity) - if not column.nullable: + if not column.nullable and not column.identity: colspec += " NOT NULL" return colspec -- cgit v1.2.1