From ef7ff058eb67d73ebeac7b125ab2a7806e14629c Mon Sep 17 00:00:00 2001 From: Mike Bayer Date: Thu, 13 Jun 2019 12:37:22 -0400 Subject: SelectBase no longer a FromClause As part of the SQLAlchemy 2.0 migration project, a conceptual change has been made to the role of the :class:`.SelectBase` class hierarchy, which is the root of all "SELECT" statement constructs, in that they no longer serve directly as FROM clauses, that is, they no longer subclass :class:`.FromClause`. For end users, the change mostly means that any placement of a :func:`.select` construct in the FROM clause of another :func:`.select` requires first that it be wrapped in a subquery first, which historically is through the use of the :meth:`.SelectBase.alias` method, and is now also available through the use of :meth:`.SelectBase.subquery`. This was usually a requirement in any case since several databases don't accept unnamed SELECT subqueries in their FROM clause in any case. See the documentation in this change for lots more detail. Fixes: #4617 Change-Id: I0f6174ee24b9a1a4529168e52e855e12abd60667 --- lib/sqlalchemy/sql/dml.py | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'lib/sqlalchemy/sql/dml.py') diff --git a/lib/sqlalchemy/sql/dml.py b/lib/sqlalchemy/sql/dml.py index c7d83fc12..5a9be7c62 100644 --- a/lib/sqlalchemy/sql/dml.py +++ b/lib/sqlalchemy/sql/dml.py @@ -47,6 +47,10 @@ class UpdateBase( _prefixes = () named_with_column = False + def _generate_fromclause_column_proxies(self, fromclause): + for col in self._returning: + col._make_proxy(fromclause) + def _process_colparams(self, parameters): def process_single(p): if isinstance(p, (list, tuple)): -- cgit v1.2.1