From 8ef4f6a53864ce9c57c4879d6b2aa0f81ddbf596 Mon Sep 17 00:00:00 2001 From: Mike Bayer Date: Mon, 17 Oct 2016 00:22:38 -0400 Subject: Add explicit copy() to Enum The Boolean and Enum types both place SchemaType second in the inheritance hierarchy. In the case of Enum, this works out that the copy() method is called from the base TypeEngine which fails to transfer _create_events. The test suite doesn't seem to work with the inhertance hierarchy set up like this as the event listeners don't work out, the _on_metadata_create and _on_table_create hooks cause the production of an adapted type which then adds event listeners that cause deque changed while iteration. It's not clear why Enum /Boolean don't have this problem. But in any case it seems like the class mechanics for these types remains fragile and would benefit from yet another refactor someday. Change-Id: Ib641a5d2321b00f58bbe98dd0c5e789374db32b2 Fixes: #3827 --- lib/sqlalchemy/sql/sqltypes.py | 3 +++ 1 file changed, 3 insertions(+) (limited to 'lib/sqlalchemy/sql') diff --git a/lib/sqlalchemy/sql/sqltypes.py b/lib/sqlalchemy/sql/sqltypes.py index 78547ccf0..118c26070 100644 --- a/lib/sqlalchemy/sql/sqltypes.py +++ b/lib/sqlalchemy/sql/sqltypes.py @@ -1330,6 +1330,9 @@ class Enum(String, SchemaType): ) assert e.table is table + def copy(self, **kw): + return SchemaType.copy(self, **kw) + def adapt(self, impltype, **kw): schema = kw.pop('schema', self.schema) metadata = kw.pop('metadata', self.metadata) -- cgit v1.2.1