From d89b2acdd7218ca179844c05be9d8f888d0c7ee6 Mon Sep 17 00:00:00 2001 From: Jason Kirtland Date: Tue, 23 Oct 2007 01:47:21 +0000 Subject: Added support for dialects that have both sequences and autoincrementing PKs. --- lib/sqlalchemy/sql/compiler.py | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) (limited to 'lib/sqlalchemy/sql') diff --git a/lib/sqlalchemy/sql/compiler.py b/lib/sqlalchemy/sql/compiler.py index 5572c2ed4..f2627eb85 100644 --- a/lib/sqlalchemy/sql/compiler.py +++ b/lib/sqlalchemy/sql/compiler.py @@ -674,9 +674,15 @@ class DefaultCompiler(engine.Compiled, visitors.ClauseVisitor): values.append((c, value)) elif isinstance(c, schema.Column): if self.isinsert: - if c.primary_key and self.dialect.preexecute_sequences and not self.inline: - values.append((c, create_bind_param(c, None))) - self.prefetch.add(c) + if (c.primary_key and self.dialect.preexecute_pk_sequences + and not self.inline): + if (((isinstance(c.default, schema.Sequence) and + not c.default.optional) or + not self.dialect.supports_pk_autoincrement) or + (c.default is not None and + not isinstance(c.default, schema.Sequence))): + values.append((c, create_bind_param(c, None))) + self.prefetch.add(c) elif isinstance(c.default, schema.ColumnDefault): if isinstance(c.default.arg, sql.ClauseElement): values.append((c, self.process(c.default.arg.self_group()))) -- cgit v1.2.1