From 31e7428b1622ce62a90d0270a2818dc785e210e9 Mon Sep 17 00:00:00 2001 From: Mike Bayer Date: Sat, 19 Dec 2020 10:59:42 -0500 Subject: Repair mssql dep tests; have __only_on__ imply __backend__ CI missed a few SQL Server tests because we run mssql-backendonly in the gerrit job. As there was a test that was "only on" mssql but didn't have backendonly, it never got run and then fails in master where we run mssql fully. Any suite that has an __only_on__ is inherently specific to a backend, so if present this should imply __backend__ so that it definitely runs when we have that backend present. This in turn meant we had to fix a few sqlite_file tests that weren't cleaning up or sharing well as they suddenly became backend tests under sqlite_file. Added a sqlite_file cleanup to test class cleanup for now. Change-Id: I9de1ceabd6596547a65c59059a55b7e5156103fd --- lib/sqlalchemy/testing/plugin/plugin_base.py | 1 + 1 file changed, 1 insertion(+) (limited to 'lib/sqlalchemy/testing/plugin') diff --git a/lib/sqlalchemy/testing/plugin/plugin_base.py b/lib/sqlalchemy/testing/plugin/plugin_base.py index b39015852..5e41f2cdf 100644 --- a/lib/sqlalchemy/testing/plugin/plugin_base.py +++ b/lib/sqlalchemy/testing/plugin/plugin_base.py @@ -553,6 +553,7 @@ def want_class(name, cls): config.options.backend_only and not getattr(cls, "__backend__", False) and not getattr(cls, "__sparse_backend__", False) + and not getattr(cls, "__only_on__", False) ): return False else: -- cgit v1.2.1