From 5ea1d673151a2a94b41d3131345464dfddaea95b Mon Sep 17 00:00:00 2001 From: Mike Bayer Date: Fri, 29 May 2009 18:56:50 +0000 Subject: - sql - Removed an obscure feature of execute() (including connection, engine, Session) whereby a bindparam() construct can be sent as a key to the params dictionary. This usage is undocumented and is at the core of an issue whereby the bindparam() object created implicitly by a text() construct may have the same hash value as a string placed in the params dictionary and may result in an inappropriate match when computing the final bind parameters. Internal checks for this condition would add significant latency to the critical task of parameter rendering, so the behavior is removed. This is a backwards incompatible change for any application that may have been using this feature, however the feature has never been documented. --- test/sql/query.py | 15 --------------- 1 file changed, 15 deletions(-) (limited to 'test/sql/query.py') diff --git a/test/sql/query.py b/test/sql/query.py index a6c419656..b428d8991 100644 --- a/test/sql/query.py +++ b/test/sql/query.py @@ -307,21 +307,6 @@ class QueryTest(TestBase): r = s.execute(userid='fred').fetchall() assert len(r) == 1 - u = bindparam('userid', unique=True) - s = users.select(and_(users.c.user_name==u, users.c.user_name==u)) - r = s.execute({u:'fred'}).fetchall() - assert len(r) == 1 - - def test_bindparams_in_params(self): - """test that a _BindParamClause itself can be a key in the params dict""" - - users.insert().execute(user_id = 7, user_name = 'jack') - users.insert().execute(user_id = 8, user_name = 'fred') - - u = bindparam('userid') - r = users.select(users.c.user_name==u).execute({u:'fred'}).fetchall() - assert len(r) == 1 - def test_bindparam_shortname(self): """test the 'shortname' field on BindParamClause.""" users.insert().execute(user_id = 7, user_name = 'jack') -- cgit v1.2.1