From 50de51a5d6abb2a2f8649091912090983dab843d Mon Sep 17 00:00:00 2001 From: Victor Uriarte Date: Sat, 11 Jun 2016 09:33:07 -0700 Subject: Replace remove with list comprehension on sql.py Help performance for #62, #135 --- sqlparse/sql.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'sqlparse') diff --git a/sqlparse/sql.py b/sqlparse/sql.py index eadd04f..43a89e7 100644 --- a/sqlparse/sql.py +++ b/sqlparse/sql.py @@ -294,7 +294,9 @@ class TokenList(Token): for token in tokens: token.parent = grp - self.tokens.remove(token) + + # Improve performance. LOOP(list.remove()) is O(n**2) operation + self.tokens = [token for token in self.tokens if token not in tokens] self.tokens.insert(idx, grp) grp.parent = self -- cgit v1.2.1