From b8eb299487248e8ca1a53b2eeebe103b2757899b Mon Sep 17 00:00:00 2001 From: Jelmer Vernooij Date: Mon, 9 May 2011 19:47:24 +0200 Subject: Fix argument in TestResultFilter.addSkip. --- python/subunit/test_results.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'python/subunit') diff --git a/python/subunit/test_results.py b/python/subunit/test_results.py index e3240e0..f312416 100644 --- a/python/subunit/test_results.py +++ b/python/subunit/test_results.py @@ -363,7 +363,7 @@ class TestResultFilter(TestResultDecorator): def addSkip(self, test, reason=None, details=None): if (self.filter_predicate(test, 'skip', reason, details)): self._buffered_calls.append( - ('addSkip', [reason], {'details': details})) + ('addSkip', [test, reason], {'details': details})) else: self._filtered() -- cgit v1.2.1 From d7f31020565d999ac02e460401068d3f7c70568d Mon Sep 17 00:00:00 2001 From: Jelmer Vernooij Date: Mon, 9 May 2011 23:00:42 +0200 Subject: Add test to make sure addSkip is preserved. --- python/subunit/tests/test_subunit_filter.py | 14 ++++++++++++++ 1 file changed, 14 insertions(+) (limited to 'python/subunit') diff --git a/python/subunit/tests/test_subunit_filter.py b/python/subunit/tests/test_subunit_filter.py index 87d4209..0675484 100644 --- a/python/subunit/tests/test_subunit_filter.py +++ b/python/subunit/tests/test_subunit_filter.py @@ -187,6 +187,20 @@ xfail todo ('stopTest', foo), ('time', date_c)], result._events) + def test_skip_preserved(self): + subunit_stream = _b('\n'.join([ + "test: foo", + "skip: foo", + ""])) + result = ExtendedTestResult() + result_filter = TestResultFilter(result) + self.run_tests(result_filter, subunit_stream) + foo = subunit.RemotedTestCase('foo') + self.assertEquals( + [('startTest', foo), + ('addSkip', foo, {}), + ('stopTest', foo), ], result._events) + def test_suite(): loader = subunit.tests.TestUtil.TestLoader() -- cgit v1.2.1