From e66b1a8f1ebaa21e00b1a2561b401b929d7a0ff9 Mon Sep 17 00:00:00 2001 From: Robert Collins Date: Mon, 2 May 2011 11:17:36 +1200 Subject: Fix thinko in addSuccess refactoring. --- python/subunit/__init__.py | 2 +- python/subunit/details.py | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) (limited to 'python/subunit') diff --git a/python/subunit/__init__.py b/python/subunit/__init__.py index 9d5d075..414b368 100644 --- a/python/subunit/__init__.py +++ b/python/subunit/__init__.py @@ -690,7 +690,7 @@ class TestProtocolClient(testresult.TestResult): self._write_details(details) else: self._stream.write(_b("\n")) - if details or error: + if details is not None or error is not None: self._stream.write(self._end_simple) def addSkip(self, test, reason=None, details=None): diff --git a/python/subunit/details.py b/python/subunit/details.py index 35bc88e..9e5e005 100644 --- a/python/subunit/details.py +++ b/python/subunit/details.py @@ -85,7 +85,10 @@ class MultipartDetailsParser(DetailsParser): return # TODO error handling field, value = line[:-1].decode('utf8').split(' ', 1) - main, sub = value.split('/') + try: + main, sub = value.split('/') + except ValueError: + raise ValueError("Invalid MIME type %r" % value) self._content_type = content_type.ContentType(main, sub) self._parse_state = self._get_name -- cgit v1.2.1