this is followup to Iaab5ce609c0dcf7085f5dd43efbd37eb4b88f17b actually retry for specified number of retries instead of raising error on first ConnectionError Change-Id: Ibca3f568b65dfea252da4b67f6d5105ba7f1ecb1
Sometimes, connections get closed by the server. This change adds retrying to the code. Change-Id: Iaab5ce609c0dcf7085f5dd43efbd37eb4b88f17b
The tooz project doesn't support Python 2 anymore, using the six library should not be necessary. Change-Id: I9886cabcd13cbc615065ceb372efbf037dff1aeb
The __future__ module [1] was used in this context to ensure compatibility between python 2 and python 3. We previously dropped the support of python 2.7 [2] and now we only support python 3 so we don't need to continue to use this module and the imports listed below. Imports commonly used and their related PEPs: - `division` is related to PEP 238 [3] - `print_function` is related to PEP 3105 [4] - `unicode_literals` is related to PEP 3112 [5] - `with_statement` is related to PEP 343 [6] - `absolute_import` is related to PEP 328 [7] [1] https://docs.python.org/3/library/__future__.html [2] https://governance.openstack.org/tc/goals/selected/ussuri/drop-py27.html [3] https://www.python.org/dev/peps/pep-0238 [4] https://www.python.org/dev/peps/pep-3105 [5] https://www.python.org/dev/peps/pep-3112 [6] https://www.python.org/dev/peps/pep-0343 [7] https://www.python.org/dev/peps/pep-0328 Change-Id: I95809cf4035a6bc487b24f9e91aaa715921ad842
The RedisDriver coordinator _stop() method removes the lock from the _acquired_locks set before calling the release() method on the lock, so the release() method should not check to see if the lock is in the set, since it never will be. This was preventing the coordinator's _stop() method from releasing the locks, so they had to timeout before another group member could take over as leader. Change-Id: Ie23d88f1a05983d7465f18a329cabc23d789a628 Closes-Bug: 1815330
After n heartbeats, the expireation time of the lock key becomes (1 + 0.5n) * timeout! Therefore, when the lock holder performs a long task and exits abnormally, the lock will not be automatically released in time. Change-Id: I2437071bb575e95083b0d57a6a0a33aaf8356113
If you're not intimately familiar with RFC 1808 it can be a bit tricky to write tooz connection strings. In addition, some drivers do not document the options that they recognize in a connection string. This can force a user to read the driver code in order to figure out how to configure tooz to use said driver, which should not be the case. This change more explicitly documents the format of the connection string, including which parts of an RFC 1808 URI it recognizes, and the options that can be passed. It also clarifies which parts of the connection string are optional (possibly because they have defaults) and which must always be included. Note that not every possible configuration is documented. For example, the postgres driver supports multiple methods of configuring the connection host and port. For consistency, I only documented the one that matches the other drivers. This should be sufficient to allow a user to write a working connection string. This change also wires the etcd3 and etcd3gw drivers into the doc index since they were missing before. Change-Id: I66e54433115f27fb54badc2173f8f6044c49aacb
The failure scenarios where LockError is raised is either: - Lock is not locked. Then it should not be in _acquired_locks, so discard should be a no-op. - Token changed. That can happen if the lock timed-out (and somebody else grabbed it). Then the lock is not longer owned anyway so let's remove it. If releasing the lock fails, there's no way heartbeat will work anyway. So just remove the lock from acquired locks and let it die anyway. Change-Id: I44db39e83db7e6c0f17079584e49c8de34b51ce1
Change-Id: Id63beaea3a0bc972a7117526aee1ad3f1ac99d84