diff options
| author | Alex Grönholm <alex.gronholm@nextday.fi> | 2019-08-18 12:40:55 +0300 |
|---|---|---|
| committer | Alex Grönholm <alex.gronholm@nextday.fi> | 2019-08-18 12:42:12 +0300 |
| commit | d799ca32f447631a2099db0d3623f341eb04f8a0 (patch) | |
| tree | 90fc64712cd1d8684f964965c452b5bb6f3b3c43 | |
| parent | 829391761185b7629e00870f300b04d275297dc8 (diff) | |
| download | wheel-git-d799ca32f447631a2099db0d3623f341eb04f8a0.tar.gz | |
Fixed building binary wheels against the limited ABI
Fixes #305.
| -rw-r--r-- | docs/news.rst | 5 | ||||
| -rw-r--r-- | tests/test_bdist_wheel.py | 12 | ||||
| -rw-r--r-- | wheel/pep425tags.py | 2 |
3 files changed, 18 insertions, 1 deletions
diff --git a/docs/news.rst b/docs/news.rst index 3650a9a..4a68bf5 100644 --- a/docs/news.rst +++ b/docs/news.rst @@ -1,6 +1,11 @@ Release Notes ============= +**UNRELEASED** + +- Fixed regression from 0.33.5 that broke building binary wheels against the + limited ABI + **0.33.5 (2019-08-17)** - Don't add the ``m`` ABI flag to wheel names on Python 3.8 (PR by rdb) diff --git a/tests/test_bdist_wheel.py b/tests/test_bdist_wheel.py index 959dfa0..40ce37f 100644 --- a/tests/test_bdist_wheel.py +++ b/tests/test_bdist_wheel.py @@ -1,4 +1,5 @@ # coding: utf-8 +import os import subprocess import sys from zipfile import ZipFile @@ -98,3 +99,14 @@ def test_build_number(dummy_dist, monkeypatch, tmpdir): filenames = set(wf.namelist()) assert 'dummy_dist-1.0.dist-info/RECORD' in filenames assert 'dummy_dist-1.0.dist-info/METADATA' in filenames + + +def test_limited_abi(monkeypatch, tmpdir): + """Test that building a binary wheel with the limited ABI works.""" + this_dir = os.path.dirname(__file__) + source_dir = os.path.join(this_dir, 'testdata', 'extension.dist') + build_dir = tmpdir.join('build') + dist_dir = tmpdir.join('dist') + monkeypatch.chdir(source_dir) + subprocess.check_call([sys.executable, 'setup.py', 'bdist_wheel', '-b', str(build_dir), + '-d', str(dist_dir)]) diff --git a/wheel/pep425tags.py b/wheel/pep425tags.py index 669624b..b9242ef 100644 --- a/wheel/pep425tags.py +++ b/wheel/pep425tags.py @@ -144,7 +144,7 @@ def get_supported(versions=None, supplied_platform=None): abi3s = set() for suffix in get_all_suffixes(): if suffix.startswith('.abi'): - abi3s.add(suffix[0].split('.', 2)[1]) + abi3s.add(suffix.split('.', 2)[1]) abis.extend(sorted(list(abi3s))) |