delta/qt-creator.git/src/plugins/projectexplorer/projectexplorer.cpp, branch master code.qt.io: qt-creator/qt-creator.git Separate session loading from project manager 2023-05-17T11:07:21+00:00 Eike Ziller eike.ziller@qt.io 2023-05-15T14:09:56+00:00 a928fee10890f964e02d290ae428af0810dcb0ad Move the generic parts to session manager and let the project manager load its parts separately. Change-Id: I14ee3311ab0c0f40444674b82cee1e4bb0fb9daf Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Christian Kandeler <christian.kandeler@qt.io> 
Move the generic parts to session manager and let the project manager
load its parts separately.

Change-Id: I14ee3311ab0c0f40444674b82cee1e4bb0fb9daf
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Session: Minimize direct use of reader when loading sessions 2023-05-17T11:04:55+00:00 Eike Ziller eike.ziller@qt.io 2023-05-15T13:19:01+00:00 b512f414bda2d6914c6209522e94f98ce1d4a570 Instead of directly reading things like the project list from the reader, add a map of "session values" in the session and read these from the reader once, then use the session to access these values while loading the details of the session. This is in preparation of separating the session loading from projectexplorer. This is similar to Session::(set)Value. We cannot use the same (set)Value methods directly though, because of differences in the handling of these values during implict and explicit default session loading. Change-Id: I9a4f38a9f958734d20d6e6eb7253f9e44ba1285e Reviewed-by: Christian Kandeler <christian.kandeler@qt.io> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> 
Instead of directly reading things like the project list from the
reader, add a map of "session values" in the session and read these from
the reader once, then use the session to access these values while
loading the details of the session. This is in preparation of separating
the session loading from projectexplorer.

This is similar to Session::(set)Value. We cannot use the same
(set)Value methods directly though, because of differences in the
handling of these values during implict and explicit default session
loading.

Change-Id: I9a4f38a9f958734d20d6e6eb7253f9e44ba1285e
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Move restoring startup session to SessionManager 2023-05-17T10:09:00+00:00 Eike Ziller eike.ziller@qt.io 2023-05-15T08:31:33+00:00 cbeac777a61322fbc2d365c7b83ead8aaaaf4bbf It needs to be done after the delayed restoring of kits, so this now implicitly depends on ICore::coreOpened coming after restoring kits has triggered on the event loop before, which is ugly, but works (and is at least guarded by a warning). Change-Id: Ie8676b1c7f4d099fb83f0f2a0f2e5677c4a0b999 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Christian Kandeler <christian.kandeler@qt.io> 
It needs to be done after the delayed restoring of kits, so this now
implicitly depends on ICore::coreOpened coming after restoring kits has
triggered on the event loop before, which is ugly, but works (and is at
least guarded by a warning).

Change-Id: Ie8676b1c7f4d099fb83f0f2a0f2e5677c4a0b999
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Session: Move some settings saving to session itself 2023-05-17T10:08:44+00:00 Eike Ziller eike.ziller@qt.io 2023-05-12T13:25:28+00:00 c3334cd1afd6af6c0705c5079766d737b6b224bc Change-Id: I306bb86f1fda03f9b34efd7101d405ed64076711 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> 
Change-Id: I306bb86f1fda03f9b34efd7101d405ed64076711
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
RunConfigurationFilter: Remove the old matchesFor() implementation 2023-05-16T07:57:06+00:00 Jarek Kobus jaroslaw.kobus@qt.io 2023-04-24T20:45:42+00:00 bc1144025631bd609cf3a16281e22962cb165cc7 Since the base class vanished, rename the filters so that they have the common prefix now. Change-Id: I21c8d1f3ea3c3ad22063d7db8be72e66d449e701 Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io> 
Since the base class vanished, rename the filters so that they have
the common prefix now.

Change-Id: I21c8d1f3ea3c3ad22063d7db8be72e66d449e701
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
ProjectExplorer: Use PagedSettings for BuildPropertiesSettingsPage 2023-05-11T14:27:25+00:00 hjk hjk@qt.io 2023-05-10T12:13:38+00:00 67acfd7076a52605d6b3b87ca362d0ff60a11277 More compact. Change-Id: Id35c3e8eeb54039a6769730fecc6b862fefc10e1 Reviewed-by: Alessandro Portale <alessandro.portale@qt.io> 
More compact.

Change-Id: Id35c3e8eeb54039a6769730fecc6b862fefc10e1
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
ILocatorFilter: Simplify Sync's onSetup in matchers 2023-04-27T08:42:34+00:00 Jarek Kobus jaroslaw.kobus@qt.io 2023-04-26T19:57:30+00:00 fad8ed8e2893f374a6211ff01c33a10acf320311 Remove no longer necessary bool return value from onSetup functions and from refresh recipe functions, see df5e3c587a045fbd3d50233ecdde0e06dccf35a3. By default, when no return bool is specified inside a function passed to Sync element, it's assumed that the return value is true. Eliminate passing "=" captures in 2 lambdas. Change-Id: I5005821444a386f70c0f05322812f98d3fd49926 Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io> 
Remove no longer necessary bool return value from onSetup
functions and from refresh recipe functions,
see df5e3c587a045fbd3d50233ecdde0e06dccf35a3.

By default, when no return bool is specified inside a function
passed to Sync element, it's assumed that the return value is true.

Eliminate passing "=" captures in 2 lambdas.

Change-Id: I5005821444a386f70c0f05322812f98d3fd49926
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
RunConfigurationLocatorFilter: Reimplement matchers() 2023-04-27T06:18:56+00:00 Jarek Kobus jaroslaw.kobus@qt.io 2023-04-12T20:11:36+00:00 86cdc6667d347c6f8af4a19f7d42dfac157a5545 Change-Id: I36a0aca3eac0ecb7988e1c68056601054837b4ad Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io> Reviewed-by: <github-actions-qt-creator@cristianadam.eu> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> 
Change-Id: I36a0aca3eac0ecb7988e1c68056601054837b4ad
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
ProjectExplorer: Keep "Run" entry in top-level project node visible 2023-04-26T09:21:24+00:00 Christian Kandeler christian.kandeler@qt.io 2023-04-25T12:56:46+00:00 963ae0a1927f80347cc643f46e60d3e5a1304008 Enable/disable instead of show/hide, for more stable UI. Fixes: QTCREATORBUG-29042 Change-Id: Ie2c37b3cb127f9dffaf42570f11b2cca6accd3fd Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Christian Stenger <christian.stenger@qt.io> Reviewed-by: <github-actions-qt-creator@cristianadam.eu> 
Enable/disable instead of show/hide, for more stable UI.

Fixes: QTCREATORBUG-29042
Change-Id: Ie2c37b3cb127f9dffaf42570f11b2cca6accd3fd
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
ProjectExplorer: Drop known namespaces 2023-04-20T16:02:46+00:00 Jarek Kobus jaroslaw.kobus@qt.io 2023-04-12T20:03:06+00:00 97ee619876840ace749aa2c976418f118614ae39 Change-Id: I969a7f6c8e54c89b047611890a7ba80f4829d73b Reviewed-by: Christian Kandeler <christian.kandeler@qt.io> Reviewed-by: <github-actions-qt-creator@cristianadam.eu> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> 
Change-Id: I969a7f6c8e54c89b047611890a7ba80f4829d73b
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>