From 4b9aaf6ca11a73d083484cbfa33fcd8a7b25d274 Mon Sep 17 00:00:00 2001 From: hjk Date: Thu, 9 Feb 2023 07:23:39 +0100 Subject: ExtensionSystem: Remove the IPlugin back pointer to pluginspec The price of having to loop in two places seems small compared to cleaner relations between the classes. There's a new hack in the helpmanager to make sure we aren't looping to often. The hack wouldn't be needed if the (odd(?)) check there weren't there. Change-Id: Ifed50213b2de8feedfb45c185808d163c00c19ca Reviewed-by: Eike Ziller Reviewed-by: --- src/plugins/coreplugin/plugininstallwizard.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'src/plugins/coreplugin/plugininstallwizard.cpp') diff --git a/src/plugins/coreplugin/plugininstallwizard.cpp b/src/plugins/coreplugin/plugininstallwizard.cpp index ae62d21564..6547c78835 100644 --- a/src/plugins/coreplugin/plugininstallwizard.cpp +++ b/src/plugins/coreplugin/plugininstallwizard.cpp @@ -7,6 +7,7 @@ #include "coreplugintr.h" #include "icore.h" +#include #include #include @@ -251,7 +252,7 @@ public: { QTC_ASSERT(m_tempDir.get(), return ); - PluginSpec *coreplugin = CorePlugin::instance()->pluginSpec(); + PluginSpec *coreplugin = PluginManager::specForPlugin(CorePlugin::instance()); // look for plugin QDirIterator it(m_tempDir->path().path(), -- cgit v1.2.1