summaryrefslogtreecommitdiff
path: root/tests
Commit message (Collapse)AuthorAgeFilesLines
...
* Do not reset favicon for same document navigationsPeter Varga2022-06-072-0/+69
| | | | | | | Fixes: QTBUG-103735 Pick-to: 6.3 6.4 Change-Id: Iee0c09cde16a825097b7c1c014655476989922c0 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Prove that the service worker works with otr profileMichal Klocek2022-06-073-10/+56
| | | | | | | | | Check registration installation and activation of service worker and add basic message ping pong test. Pick-to: 6.3 6.4 Change-Id: Ia446553ccbc62b45a5d6313cbbdf15108adcdd36 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* unblacklist passing tests 2022Anna Wojciechowska2022-06-051-12/+0
| | | | | Change-Id: I3eec851a59e49c700945268c1421d18f4868d3c5 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix issues in PdfLinkDelegateShawn Rutledge2022-06-041-4/+4
| | | | | | | | | | - gesturePolicy must be set to take an exclusive grab, to avoid letting events propagate to another TapHandler in TableView - behavior was incorrect on the touchscreen - fixed doc warnings about the undocumented link arguments Change-Id: Ic438383b6b6d67936ce2b88b84ef131f41e0d2fb Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
* Add PdfLinkDelegate instead of link decoration style propertiesShawn Rutledge2022-06-041-0/+193
| | | | | | | | | | | | | | | | This simplifies PdfStyle somewhat. PdfLinkDelegate could still be replaced or augmented via file selectors, but we don't expect to need to, since link delegates are already non-visual. [ChangeLog][QtPDF] A PdfLinkDelegate will now be instantiated on top of each hyperlink in the PdfMultiPageView, PdfScrollablePageView and PdfPageView components, for event handling and to provide tapped() and contextMenuRequested() signals. It is non-visual by default, but can be customized, for example to draw underlines under hyperlinks if the PDF documents are not expected to have them already. Change-Id: Ib3726e7220a0c3858db564ca8d53a04625a11950 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
* Rename QQuickPdfSelection fromPoint/toPoint properties to from and toShawn Rutledge2022-06-041-2/+2
| | | | | | | It was a suggestion during API review. Change-Id: I54425bbebb90b05a2cee1cb00d51c4d61edb8784 Reviewed-by: Doris Verria <doris.verria@qt.io>
* Add QPdfDocument::pageLabel(int) and pageModel propertyShawn Rutledge2022-06-047-18/+42
| | | | | | | | | | | This API is available for both C++ and QML. The pageModel makes it easier to populate item-views with per-page information, such as thumbnails labeled with page labels. Fixes: QTBUG-102271 Change-Id: I70df481b378efed0327e7bb89a63c7669daecc70 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
* Skip tst_UIDelegates::contextMenu on macOSShawn Rutledge2022-06-041-0/+3
| | | | | | | Task-number: QTBUG-103354 Task-number: QTBUG-101744 Change-Id: I6faf1d9cc2110d527050804e15ecb16ff12f528b Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix flakiness of jsServiceWorker testMichal Klocek2022-06-041-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | This is an interesting issue as in the test sometimes first party url of intercepted request has "sw.js" instead of "sw.html". After deep debug of the issue the reason behind is that a service worker registration job checks the registration for given scope and the key, this in the turn will check storage in ServiceWorkerStorage::FindRegistrationForScope. Now if registration is found this will trigger service worker update checker, which fires the request check for newer version for sw.js and makes an intercepted request with sw.js as first party url. This of course brakes the test. Do not use the storage in that test, and let the service worker registration job do full "install" & "register" cycle instead of running "update" phase. As a side note , using off the record profile makes test run faster as opening the storage and closing it is costly. Pick-to: 6.3 6.2 Change-Id: If13a4fcf0014cc5c76cb8ed14e60f2e5e29c67ef Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Renumber pages in test.pdfShawn Rutledge2022-05-312-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | Give them unique labels. This was done with pdftk: $ pdftk resources/test.pdf update_info_utf8 update output test.pdf where the file "update" contains PageLabelBegin PageLabelNewIndex: 1 PageLabelStart: 1 PageLabelPrefix: Qt PageLabelNumStyle: NoNumber PageLabelBegin PageLabelNewIndex: 2 PageLabelStart: 1 PageLabelNumStyle: DecimalArabicNumerals PageLabelBegin PageLabelNewIndex: 3 PageLabelStart: 1 PageLabelNumStyle: LowercaseRomanNumerals The instructions to do this came from https://emacs.stackexchange.com/questions/58315/edit-pdf-page-labels-in-pdf-tools Task-number: QTBUG-102271 Change-Id: I97df7ca538690baf3329fcbef371dcd92c4d8966 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
* Rename QPdfDocument::pageSize() to QPdfDocument::pagePointSize()Shawn Rutledge2022-05-312-2/+2
| | | | | | | | It is in fact the size in points (1/72 of an inch), so we might as well be consistent about the naming between QML and C++ APIs. Change-Id: I8f8b05eeecc635a4d105558959834ae0e15add81 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
* Fix assert after qtbase changeAllan Sandfeld Jensen2022-05-311-10/+10
| | | | | | | | | Avoid using high finger ids. Pick-to: 6.3 Task-number: QTBUG-103859 Change-Id: I4be5466b094dec1cc084ecb7ac61448a93c02637 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Include moc filesAllan Sandfeld Jensen2022-05-313-0/+6
| | | | | | | | Faster to build and gives smaller binaries Fixes: QTBUG-103291 Change-Id: Iab52995e03c13a4c5b185750028c449a19d98d93 Reviewed-by: Marc Mutz <marc.mutz@qt.io>
* Remove PdfPageView.currentPage propertyShawn Rutledge2022-05-311-1/+1
| | | | | | | It was just an alias for currentFrame. Change-Id: Ib16f579b1905cf5fe43496553ebde054d474a7c7 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
* Rename QPdfNavigationStack to QPdfPageNavigator; QML type tooShawn Rutledge2022-05-271-1/+1
| | | | | | | | | | | | | | | | | This might reduce some confusion about the fact that the back/forward "stack" isn't strictly a stack in the data structure sense: it's more like QUndoStack. It causes a QML source incompatibility relative to Qt 5, but keeps the C++ class name the same as it has been in QtPdf for a long time. Amends 3ad445f9f24a9d3f259ed1781460a63346a728e4 [ChangeLog][QtPDF] The PdfNavigationStack QML type has been renamed to PdfPageNavigator, matching the C++ type QPdfPageNavigator. These remember navigation history within a document, and are helpful to implement back/forward buttons similar to those on a web browser in both Qt Quick and widget-based viewer applications. Change-Id: Id8dc17aa416bb7064b1f0f300a47c07c83b7f47e Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
* Implement File System Access permission APISzabolcs David2022-05-262-6/+40
| | | | | | | | | | | | Allow web pages to safely access the local file system by exposing a permission API. Permissions are stored in-memory. The built-in access rules are the same as the behavior of Chrome: JS can't request access to system libraries, sensitive directories and the application itself. Task-number: QTBUG-97829 Change-Id: Ic675422cafbad5a90243b4fa8f0749c46afa192c Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix local->remote user navigationAllan Sandfeld Jensen2022-05-251-0/+65
| | | | | | | | | Specifically allow user initiated navigation of the mainframe. Pick-to: 6.3 6.2 Fixes: QTBUG-103778 Change-Id: I4e3d6b4fb606bd0c3cf66e090fba3c97c8c535b4 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Remove QPdfBookmarkModel::structureModeShawn Rutledge2022-05-241-65/+0
| | | | | | | | | | | Bookmarks are naturally a tree. It's unusual for a QAIM to have the internal ability to flatten a tree to a list, and we don't need it in any of our viewers or examples. This patch could be reverted if it turns out that anybody misses this feature; or else flattening could be done in a proxy model. Change-Id: I5cf60a39cb699932cc7c61e33a5129323d648344 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
* QPdfBookmarkModel: replace StructureMode enum with an enum classShawn Rutledge2022-05-241-3/+3
| | | | | Change-Id: I6335c1b13ef50dc04d50bd1ce66b3524e2615b3f Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
* QPdfDocument: use enum classesShawn Rutledge2022-05-243-63/+63
| | | | | Change-Id: Iad3f8da130abe86a464d63323920a2a39d6fa955 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
* Un-blacklist QtPdf password testsShawn Rutledge2022-05-191-6/+0
| | | | | Change-Id: Ife034dc0578268c1bed660bbacc163f393a50c29 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
* Keep page's zoom level on loading new urlsKirill Burtsev2022-05-152-19/+67
| | | | | | | | | | | | Ammends d236c5a8a3. Zoom level was set as a temporal one, which is invalidated each time when a renderer process or widget are changed (on new navigation, for example), so it needs to be reapplied. Pick-to: 6.3 6.2 5.15 Fixes: QTBUG-101030 Change-Id: Iecff9686fbe2b79e99b46f67cab92f66127be085 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Add NavigateOnDrop settingsAllan Sandfeld Jensen2022-05-133-4/+37
| | | | | | | | | | Some applications want this to avoid users navigating away from their app content. [ChangeLog][Settings] NavigateOnDropEnabled added, enabled by default. Change-Id: I2cc370f60ef42c708042cbc2503207f8254cf932 Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
* Fix touch input for html's popup in quick implKirill Burtsev2022-05-124-39/+132
| | | | | | | | | | | | | | Ammends 292f573f4e. Now that touch events are forwarded to popup delegate also instead of synthesized mouse events, the bug with touch event being ignored became present. Also extend testing of touch events for html popups. Task-number: QTBUG-79254 Fixes: QTBUG-103217 Pick-to: 6.2 6.3 Change-Id: I097a6617493355c7603fef8eb41025e299a6e809 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Add convenience constructors to QWebEngineViewAllan Sandfeld Jensen2022-05-091-11/+7
| | | | | | | | Make it easier to use alternative profiles without having to use QWebEnginePage directly. Change-Id: I8406c9ee3b453f7ff45e64bb05d0f5ad57e389c4 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Quick: Add support for replacing touch handles with delegatesBalazs Egedi2022-05-041-1/+4
| | | | | | Task-number: QTBUG-85043 Change-Id: I1c87aff352e07eb309d5ba8747b9e50a191d478e Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* PDF example and manual test: add GridView for thumbnailsShawn Rutledge2022-04-291-0/+105
| | | | | | | | | Change the PdfDocument's id to doc, because in the GridView delegate, PdfPageImage { document: document } causes trouble (even though the same sort of binding was ok elsewhere). Change-Id: I9eafd818c25a31bef50b0b7fba36449c1dcf884a Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
* Fix navigation to non-local URLsAllan Sandfeld Jensen2022-04-262-2/+10
| | | | | | | | | They are passed in another part of the DropItem object. Task-number: QTBUG-102192 Pick-to: 6.3 6.2 5.15 Change-Id: If52a88ce2688c25ea0edcc0d1e8f962f2cdd29dd Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
* QPdfBookmarkModel: add location and zoom rolesShawn Rutledge2022-04-241-0/+28
| | | | | | | | | | | We need them for more accurate navigation. Switch to initializing BookmarkNode's variables where declared, while we're at it. Task-number: QTBUG-77510 Change-Id: Ia6762c9b6336c9148a85ad782e71e5b59feab754 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
* Turn QPdfBookmarkModel::Role into an enum classShawn Rutledge2022-04-221-36/+36
| | | | | | | | | - link, search and bookmark models have similar role names now - being an enum class allows the role name to be shorter - the Role enum name is the same as the name in roleNames(), lowercased Change-Id: I2e710d7acb8479995d82ef2d324807b6cd4e10e5 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
* Introduce http status code domain for loading infoKirill Burtsev2022-04-182-8/+9
| | | | | | | | | | | | | | | | Fix inconsistency in reporting load info error category for http status codes, which across versions was reported either as internal error category or just no error domain. Add new separate domain for http status codes. [ChangeLog][QWebEngineLoadingInfo] Added HttpStatusCodeDomain for http status code range of errors Fixes: QTBUG-94963 Change-Id: I9fd496248c6fa33c424d758e9a0be99758aaf061 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Benjamin Terrier <b.terrier@gmail.com> Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Adapt Qt-style cmake for manual testsMartin Negyokru2022-04-144-110/+50
| | | | | | | | | The tests can built with qt-cmake-standalone-test. Make then directly openable in Creator. Pick-to: 6.3 6.2 Change-Id: Iceae2305912d3854959b3a266d19d3e7344557e7 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Fix granted file access after local/remote access cleanupAllan Sandfeld Jensen2022-04-142-0/+33
| | | | | | | | | | | We forgot to check for files specifically granted access to. This blocked a number of features including dropping local files. Pick-to: 6.3 6.2 Task-number: QTBUG-102192 Change-Id: I5d34d9ba5351ec179df5896e64cc95c5481c7dc2 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
* Add manual tests for PdfPageViewShawn Rutledge2022-04-122-0/+582
| | | | | | | | | | | | | | | | | | | | Before ff13e6532975b5372280c02061cb1b7227cf6699 the pdfviewer example used PdfPageView; but from then until now, it was not used anywhere. Now there's a manual test, slightly more refined than it was then. PdfPageView no longer takes care of its own positioning (scrolling or panning by whatever means): the user has the responsibility for that (as in the pdfPageView manual test). But it still does its own pinch zoom and text selection, so it's not completely devoid of event handlers. This also makes it suitable for the the multipleDocuments manual test, which creates a fullscreen transparent MDI window with fake windows inside, one per document opened. Worked around some issues by having PdfPageView as the top-level item in the Component. Fixes: QTBUG-102295 Change-Id: Iedb9ed7d15fa3461c07bd5d6ea54a30c20f747da Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
* Refactor 'inputmethods' manual testMartin Negyokru2022-04-085-30/+62
| | | | | | | | | | | Fix build after qtbase patch: 19f9b0d5f5 Disable copying and assigning of QEvent Stop test execution when window is closed Change-Id: I038421ce6cd034b669d5601e8fda1ee33cdf0566 Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io> Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* Move QQuickPdfNavStack core into QPdfNavigationStack; use in QPdfViewShawn Rutledge2022-04-084-212/+1
| | | | | | | | | | | | | | | QQuickPdfNavigationStack was implemented independently until now, but users will need the same functionality in widget-based PDF viewers. QPdfPageNavigation on the other hand may have eventually had the same aspiration, but was just a glorified up/down counter thus far, with questionable API; so we get rid of it, and make the API for page navigation as much the same as possible between Quick and Widgets. We rename push() to jump() along with removing the emitJumped argument. Now jump() always emits (so we have to be more careful when to call it). Change-Id: Icb07158a351e29b81e58ec037cd323bc0f54a1a1 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
* Resolve status code for http response with failureKirill Burtsev2022-04-071-13/+61
| | | | | | | | | | | | | | All non-default https status codes are hidden under net::ERR_HTTP_RESPONSE_CODE_FAILURE error of network stack. Handle successful load case and set the real http status code for error. Also set localized load error description only for http codes. Pick-to: 6.2 6.3 Fixes: QTBUG-46860 Fixes: QTBUG-61100 Task-number: QTBUG-94963 Change-Id: I81e083441d1814fb530f39ea3da1c4ef52b7da59 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix build with libc++Qt Submodule Update Bot2022-04-072-6/+5
| | | | | | | | | | | | Fix build with libc++ on linux by adding missing use_libcxx parameter. Check if re2 and poppler can be used as they use std::string in their api. Add compiler test to check that. Pick-to: 6.3 6.2 Change-Id: I74bf79b8443ad470621c1a2e0c9dc768d4cca1f1 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Expose PdfBookmarkModel to QML; use with TreeView in manual testShawn Rutledge2022-04-062-0/+378
| | | | | | | | | | | | | | | | | | | | | | | | | - TreeViewDelegate uses Qt::DisplayRole by default, so we need it to map to the text we want to display, in the roleNames() hash. But asking explicitly for the TitleRole is OK too (as before). - In QML, the document property must be a QQuickPdfDocument, whereas in C++ QPdfDocument is used directly; so we shadow the document property for QML. Therefore QML_EXTENDED(QPdfBookmarkModel) does not work: we need real inheritance to get real property shadowing. - Added tests/manual/quick/pdf/bookmarks.qml with a TreeView - Clicking the TreeViewDelegate expands the subtree if there is one; but it also goes to the destination in the PDF, whether there is a subtree or not. But this can be fixed in TreeViewDelegate. - Added tests/manual/quick/pdf/bookmarks-list.qml to test the case with structureMode: PdfBookmarkModel.ListMode (using ListView) test.pdf is uninteresting for this purpose: there is only one bookmark; but you can run these tests with an optional argument like this: qml bookmarks.qml -style Material -- ~/path/to/some.pdf qml bookmarks-list.qml -- ~/path/to/some.pdf Change-Id: I65d12a3d9b8ef0f0fa2bc99003430324fd759dcb Reviewed-by: Topi Reiniƶ <topi.reinio@qt.io>
* Avoid crash due to QWindow being changed under usAllan Sandfeld Jensen2022-04-051-4/+8
| | | | | | | | | | QTest::keyClick sends two events to the same QWindow with a wait in between. The QWindow can become invalid during that wait, so avoid using this method. Task-number: QTBUG-102253 Change-Id: I67d27d2bba8dd73d5918e8205e7250443799b2be Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io>
* Adaptations for Chrome 98Allan Sandfeld Jensen2022-03-295-16/+17
| | | | | Change-Id: I607604f85a111a69da77ca949dddf3399b9721b3 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* Adaptations for Chrome 96Allan Sandfeld Jensen2022-03-291-1/+1
| | | | | Change-Id: I40039658762b8788a0be57bd186efab71f3e4448 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* Add missing cmake files for manual testsMartin Negyokru2022-03-296-0/+154
| | | | | Change-Id: I53fe56d903a636dafb2cc4108350807574cb39a3 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Fix qimage compare in tst_webenginepageMichal Klocek2022-03-251-0/+2
| | | | | | | | | | | | After 019d0dd4 in qtbase comparing two images also checks a color space. Simply copy the color space for the comparison. Fixes: QTBUG-101935 Change-Id: I446ee21336e242443960dab7dd4d47681bd598d9 Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io> (cherry picked from commit cddf9c264532105fc9d15d41cfd7585299ccab8f) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Avoid crashing on context free web actionsAllan Sandfeld Jensen2022-03-242-0/+39
| | | | | | | | | | If a web action that depends on a context is called, do nothing instead of crashing. Pick-to: 6.3 6.2 Fixes: QTBUG-101724 Change-Id: I7a0040a58e9dc7fa14f0cae71cf1bcd086b61c54 Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
* Fix qrc sources for QWebEngineScriptAllan Sandfeld Jensen2022-03-172-1/+6
| | | | | | | | Fixes: QTBUG-96525 Change-Id: I39d6247c0dd0e55e4fb91b176f34e676eeabbcdd Reviewed-by: Michal Klocek <michal.klocek@qt.io> (cherry picked from commit ce2d6a94ce99f8d6f82fbcbf45603f8eb7a92957) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Update PDF manual testsShawn Rutledge2022-03-074-28/+26
| | | | | | | | | | | - remove import versions - use Qt Quick Dialogs - use PdfPageImage in the more complex ones The BusyIndicator seems to work better while pages are rendering. Change-Id: Ie9588cff897f969d679199f2fdb113079bf8685d Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
* PDF viewer and manual test: support password-protected documentsShawn Rutledge2022-03-071-0/+21
| | | | | | | | | | | | | | | The multipage example was OK already; this adds the same password-prompt dialog to the single-page-at-a-time pdfviewer example and to the withdoc.qml manual test. Also, the dialogs seem to size themselves better if we explicitly set the contentItem properties. And an error dialog should not have an OK button but a Close button: the error is not OK, but the example does not provide a way to try to fix it either. Fixes: QTBUG-83988 Fixes: QTBUG-96574 Change-Id: I9d8c3cbe1f955cea4319982869ec9180d7c8666c Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
* Add qml user script collection unit testMichal Klocek2022-03-022-0/+153
| | | | | | | | | | | | Adds overlooked unit test to test collection API. Note this test throws bunch of warnings "Can't open user script ..." and it would require dummy js files just to suppress those. Pick-to: 6.3 6.2 Change-Id: Iddf8150c5fee7a29b3dba75066fa51070053d69b Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Blacklist CertificateError::test_errorMichal Klocek2022-02-281-0/+3
| | | | | | | | | | | This test started to fail in ci, however c++ counterpart works fine. Task-number: QTBUG-101215 Change-Id: Ic94409b6db06f285d11ab10295d5ebaa831c0fa5 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit 123394142c887e049131b823933de88f258152b0) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>