summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAllan Sandfeld Jensen <allan.jensen@digia.com>2013-11-26 13:45:55 +0100
committerThe Qt Project <gerrit-noreply@qt-project.org>2013-12-12 16:46:05 +0100
commit8d010375486b50f89951ca85c76c8db4d1b14e49 (patch)
tree0da923c5f70c2baa132b1f286441a99efb6369cd
parent4f8a92b738e29f93c01d0be70c8e5e7686af94b0 (diff)
downloadqtwebkit-8d010375486b50f89951ca85c76c8db4d1b14e49.tar.gz
Revert "[EFL][WK2] Never create WebCore scrollbars for EFL/WK2"
This reverts commit 373d3d52252ea44fdd5d17635459d18d3d4b3e94. Allow FrameViews to have hidden Scrollbars. This fixes key event scrolling in fixed layout mode. Task-number: QTBUG-34203 Change-Id: Idf157d51e01ba4d831e62d1e24f7283030c8e177 Reviewed-by: Michael Bruning <michael.bruning@digia.com> Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
-rw-r--r--Source/WebCore/page/FrameView.cpp18
-rw-r--r--Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp4
2 files changed, 1 insertions, 21 deletions
diff --git a/Source/WebCore/page/FrameView.cpp b/Source/WebCore/page/FrameView.cpp
index 209030309..4823b48d0 100644
--- a/Source/WebCore/page/FrameView.cpp
+++ b/Source/WebCore/page/FrameView.cpp
@@ -4147,24 +4147,6 @@ void FrameView::removeChild(Widget* widget)
bool FrameView::wheelEvent(const PlatformWheelEvent& wheelEvent)
{
- // Note that to allow for rubber-band over-scroll behavior, even non-scrollable views
- // should handle wheel events.
-#if !ENABLE(RUBBER_BANDING)
- if (!isScrollable())
- return false;
-#endif
-
- if (delegatesScrolling()) {
- IntSize offset = scrollOffset();
- IntSize newOffset = IntSize(offset.width() - wheelEvent.deltaX(), offset.height() - wheelEvent.deltaY());
- if (offset != newOffset) {
- ScrollView::scrollTo(newOffset);
- scrollPositionChanged();
- frame()->loader()->client()->didChangeScrollOffset();
- }
- return true;
- }
-
// We don't allow mouse wheeling to happen in a ScrollView that has had its scrollbars explicitly disabled.
if (!canHaveScrollbars())
return false;
diff --git a/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp b/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp
index 0c02f31e5..657a25dcc 100644
--- a/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp
+++ b/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp
@@ -1202,11 +1202,9 @@ void WebFrameLoaderClient::transitionToCommittedForNewPage()
m_frameCameFromPageCache = false;
- ScrollbarMode defaultScrollbarMode = shouldHideScrollbars ? ScrollbarAlwaysOff : ScrollbarAuto;
-
m_frame->coreFrame()->createView(webPage->size(), backgroundColor, isTransparent,
IntSize(), currentFixedVisibleContentRect, shouldUseFixedLayout,
- defaultScrollbarMode, /* lock */ shouldHideScrollbars, defaultScrollbarMode, /* lock */ shouldHideScrollbars);
+ ScrollbarAuto, /* lock */ shouldHideScrollbars, ScrollbarAuto, /* lock */ shouldHideScrollbars);
if (int minimumLayoutWidth = webPage->minimumLayoutSize().width()) {
int minimumLayoutHeight = std::max(webPage->minimumLayoutSize().height(), 1);