<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/rabbitmq-server-git.git, branch mergify/bp/v3.9.x/pr-4317</title>
<subtitle>github.com: rabbitmq/rabbitmq-server.git
</subtitle>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/rabbitmq-server-git.git/'/>
<entry>
<title>Bump (c) year</title>
<updated>2022-03-20T22:01:00+00:00</updated>
<author>
<name>Michael Klishin</name>
<email>klishinm@vmware.com</email>
</author>
<published>2022-03-20T21:21:56+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/rabbitmq-server-git.git/commit/?id=8e9c56df39aea833b5302d1216f2b6ca0fda2aed'/>
<id>8e9c56df39aea833b5302d1216f2b6ca0fda2aed</id>
<content type='text'>
(cherry picked from commit c38a3d697d83cafa376592a9aa213347ae1a68af)
(cherry picked from commit 515780f5d4e036efb2c568214d7b1b505d5b560b)

# Conflicts:
#	deps/rabbit/src/rabbit_classic_queue_index_v2.erl
#	deps/rabbit/src/rabbit_classic_queue_store_v2.erl
#	deps/rabbit/src/rabbit_fifo.erl
#	deps/rabbit/src/rabbit_fifo.hrl
#	deps/rabbit/src/rabbit_fifo_dlx.erl
#	deps/rabbit/src/rabbit_fifo_dlx.hrl
#	deps/rabbit/src/rabbit_fifo_dlx_client.erl
#	deps/rabbit/src/rabbit_fifo_dlx_sup.erl
#	deps/rabbit/src/rabbit_fifo_dlx_worker.erl
#	deps/rabbit/src/rabbit_fifo_v1.erl
#	deps/rabbit/test/classic_queue_prop_SUITE.erl
#	deps/rabbit/test/quorum_queue_SUITE.erl
#	deps/rabbit/test/rabbit_fifo_dlx_SUITE.erl
#	deps/rabbit/test/rabbit_fifo_dlx_integration_SUITE.erl
#	deps/rabbit_common/src/rabbit_date_time.erl
#	deps/rabbitmq_shovel_management/src/rabbit_shovel_mgmt.hrl
#	deps/rabbitmq_shovel_management/src/rabbit_shovel_mgmt_util.erl
#	deps/rabbitmq_stream/test/rabbit_stream_manager_SUITE.erl
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
(cherry picked from commit c38a3d697d83cafa376592a9aa213347ae1a68af)
(cherry picked from commit 515780f5d4e036efb2c568214d7b1b505d5b560b)

# Conflicts:
#	deps/rabbit/src/rabbit_classic_queue_index_v2.erl
#	deps/rabbit/src/rabbit_classic_queue_store_v2.erl
#	deps/rabbit/src/rabbit_fifo.erl
#	deps/rabbit/src/rabbit_fifo.hrl
#	deps/rabbit/src/rabbit_fifo_dlx.erl
#	deps/rabbit/src/rabbit_fifo_dlx.hrl
#	deps/rabbit/src/rabbit_fifo_dlx_client.erl
#	deps/rabbit/src/rabbit_fifo_dlx_sup.erl
#	deps/rabbit/src/rabbit_fifo_dlx_worker.erl
#	deps/rabbit/src/rabbit_fifo_v1.erl
#	deps/rabbit/test/classic_queue_prop_SUITE.erl
#	deps/rabbit/test/quorum_queue_SUITE.erl
#	deps/rabbit/test/rabbit_fifo_dlx_SUITE.erl
#	deps/rabbit/test/rabbit_fifo_dlx_integration_SUITE.erl
#	deps/rabbit_common/src/rabbit_date_time.erl
#	deps/rabbitmq_shovel_management/src/rabbit_shovel_mgmt.hrl
#	deps/rabbitmq_shovel_management/src/rabbit_shovel_mgmt_util.erl
#	deps/rabbitmq_stream/test/rabbit_stream_manager_SUITE.erl
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge pull request #4313 from rabbitmq/mergify/bp/v3.9.x/pr-4309</title>
<updated>2022-03-20T15:12:54+00:00</updated>
<author>
<name>Michael Klishin</name>
<email>michael@clojurewerkz.org</email>
</author>
<published>2022-03-20T15:12:54+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/rabbitmq-server-git.git/commit/?id=3bcb6881908d572de3041fe7d0a6b51ef48a44f3'/>
<id>3bcb6881908d572de3041fe7d0a6b51ef48a44f3</id>
<content type='text'>
Naming from #4305 (backport #4307) (backport #4309)</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Naming from #4305 (backport #4307) (backport #4309)</pre>
</div>
</content>
</entry>
<entry>
<title>Merge pull request #4312 from rabbitmq/mergify/bp/v3.9.x/pr-4310</title>
<updated>2022-03-20T12:53:12+00:00</updated>
<author>
<name>Michael Klishin</name>
<email>michael@clojurewerkz.org</email>
</author>
<published>2022-03-20T12:53:12+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/rabbitmq-server-git.git/commit/?id=559b5334b7b1521dbbc1c73be670e9677bce6c80'/>
<id>559b5334b7b1521dbbc1c73be670e9677bce6c80</id>
<content type='text'>
Adopt latest rabbitmq-server-buildenv:linux-erlang-23.3 for RBE (backport #4308) (backport #4310)</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Adopt latest rabbitmq-server-buildenv:linux-erlang-23.3 for RBE (backport #4308) (backport #4310)</pre>
</div>
</content>
</entry>
<entry>
<title>Naming from #4305</title>
<updated>2022-03-20T12:52:26+00:00</updated>
<author>
<name>Michael Klishin</name>
<email>klishinm@vmware.com</email>
</author>
<published>2022-03-19T21:58:02+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/rabbitmq-server-git.git/commit/?id=6decaaff977ad8898f35f7a6d580c03c43e16b48'/>
<id>6decaaff977ad8898f35f7a6d580c03c43e16b48</id>
<content type='text'>
(cherry picked from commit a43d9890d51537afde003e66f7e808e3a03fb298)
(cherry picked from commit 16b19baf0f1b90ad69add14de2cba306d6f5fc54)
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
(cherry picked from commit a43d9890d51537afde003e66f7e808e3a03fb298)
(cherry picked from commit 16b19baf0f1b90ad69add14de2cba306d6f5fc54)
</pre>
</div>
</content>
</entry>
<entry>
<title>Use latest rbe-erlang-platform/linux-erlang-23.3</title>
<updated>2022-03-20T12:49:02+00:00</updated>
<author>
<name>GitHub</name>
<email>noreply@github.com</email>
</author>
<published>2022-03-20T03:03:36+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/rabbitmq-server-git.git/commit/?id=15d19910b444d242130ea571da74c36acf86b2cd'/>
<id>15d19910b444d242130ea571da74c36acf86b2cd</id>
<content type='text'>
for remote build execution (RBE) with BuildBuddy

(cherry picked from commit 3fa7357df93e14ccc78fc0a9f1b235fc88a487b8)
(cherry picked from commit e7ba67c8a11b25839bf47eeb2d18c7db1ee3eeb4)
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
for remote build execution (RBE) with BuildBuddy

(cherry picked from commit 3fa7357df93e14ccc78fc0a9f1b235fc88a487b8)
(cherry picked from commit e7ba67c8a11b25839bf47eeb2d18c7db1ee3eeb4)
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge pull request #4299 from rabbitmq/mergify/bp/v3.9.x/pr-4298</title>
<updated>2022-03-18T13:25:09+00:00</updated>
<author>
<name>Michael Klishin</name>
<email>michael@clojurewerkz.org</email>
</author>
<published>2022-03-18T13:25:09+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/rabbitmq-server-git.git/commit/?id=73f1ad4bb163e0612fc1e7e6171d0153c7332415'/>
<id>73f1ad4bb163e0612fc1e7e6171d0153c7332415</id>
<content type='text'>
Make backing_queue_SUITE fast on macOS (backport #4297) (backport #4298)</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Make backing_queue_SUITE fast on macOS (backport #4297) (backport #4298)</pre>
</div>
</content>
</entry>
<entry>
<title>Make backing_queue_SUITE fast on macOS</title>
<updated>2022-03-18T13:07:09+00:00</updated>
<author>
<name>Loïc Hoguin</name>
<email>lhoguin@vmware.com</email>
</author>
<published>2022-03-18T11:47:22+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/rabbitmq-server-git.git/commit/?id=2ba7792a0a994a8c7d273eb6b73b21f099ab0907'/>
<id>2ba7792a0a994a8c7d273eb6b73b21f099ab0907</id>
<content type='text'>
This very small patch requires extended explanations. The patch
swaps two lines in a rabbit_variable_queue setup: one which sets
the memory hint to 0 which results in reduce_memory_usage to
always flush to disk and fsync; and another which publishes a
lot of messages to the queue that will after that point be
manipulated further to get the queue in the exact right state
for the relevant tests.

The problem with calling reduce_memory_usage after every single
message has been published is not writing to disk (v2 tests do
not suffer from performance issues in that regard) but rather
that rabbit_queue_index will always flush its journal (containing
the one message), which results in opening the segment file,
appending to it, and closing it. The file handling is done
by file_handle_cache which, in this case, will always fsync
the data before closing the file. And that's this one fsync
per message that makes the relevant tests very slow.

By swapping the lines, meaning we publish all messages first
and then set the memory hint to 0, we end up with a single
reduce_memory_usage call that results in an fsync, at the
end. (There may be other fsyncs as part of normal operations.)
And still get the same result because all messages will have
been flushed to disk, only this time in far fewer operations.

This doesn't seem to have been causing problems on CI which
already runs the tests very fast but should help macOS and
possibly other development environments.

(cherry picked from commit 7198d4720ba051851e2242ad1859f32f66b3226b)
(cherry picked from commit 6773df447d7cf662d44207ea2c41f8b873478b00)
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This very small patch requires extended explanations. The patch
swaps two lines in a rabbit_variable_queue setup: one which sets
the memory hint to 0 which results in reduce_memory_usage to
always flush to disk and fsync; and another which publishes a
lot of messages to the queue that will after that point be
manipulated further to get the queue in the exact right state
for the relevant tests.

The problem with calling reduce_memory_usage after every single
message has been published is not writing to disk (v2 tests do
not suffer from performance issues in that regard) but rather
that rabbit_queue_index will always flush its journal (containing
the one message), which results in opening the segment file,
appending to it, and closing it. The file handling is done
by file_handle_cache which, in this case, will always fsync
the data before closing the file. And that's this one fsync
per message that makes the relevant tests very slow.

By swapping the lines, meaning we publish all messages first
and then set the memory hint to 0, we end up with a single
reduce_memory_usage call that results in an fsync, at the
end. (There may be other fsyncs as part of normal operations.)
And still get the same result because all messages will have
been flushed to disk, only this time in far fewer operations.

This doesn't seem to have been causing problems on CI which
already runs the tests very fast but should help macOS and
possibly other development environments.

(cherry picked from commit 7198d4720ba051851e2242ad1859f32f66b3226b)
(cherry picked from commit 6773df447d7cf662d44207ea2c41f8b873478b00)
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge pull request #4295 from rabbitmq/mergify/bp/v3.9.x/pr-4294</title>
<updated>2022-03-18T10:08:14+00:00</updated>
<author>
<name>Philip Kuryloski</name>
<email>kuryloskip@vmware.com</email>
</author>
<published>2022-03-18T10:08:14+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/rabbitmq-server-git.git/commit/?id=fe2a768a612bf157ec21ffd6f560dfe3c418a231'/>
<id>fe2a768a612bf157ec21ffd6f560dfe3c418a231</id>
<content type='text'>
Adopt latest rabbitmq-server-buildenv:linux-erlang-24.3 for RBE (backport #4293) (backport #4294)</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Adopt latest rabbitmq-server-buildenv:linux-erlang-24.3 for RBE (backport #4293) (backport #4294)</pre>
</div>
</content>
</entry>
<entry>
<title>Use latest rbe-erlang-platform/linux-erlang-24.3</title>
<updated>2022-03-18T09:52:29+00:00</updated>
<author>
<name>GitHub</name>
<email>noreply@github.com</email>
</author>
<published>2022-03-18T03:06:44+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/rabbitmq-server-git.git/commit/?id=a69a3717ae5b646f3c9cf6b3ac11c286fd407103'/>
<id>a69a3717ae5b646f3c9cf6b3ac11c286fd407103</id>
<content type='text'>
for remote build execution (RBE) with BuildBuddy

(cherry picked from commit 7c02878c684e8742ae006b862350c1951be38c6b)
(cherry picked from commit f2642c7b40a5e0a10eee64cd7c6af8f7dab6df7e)
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
for remote build execution (RBE) with BuildBuddy

(cherry picked from commit 7c02878c684e8742ae006b862350c1951be38c6b)
(cherry picked from commit f2642c7b40a5e0a10eee64cd7c6af8f7dab6df7e)
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge pull request #4289 from rabbitmq/mk-3.9.14-release-notes-update</title>
<updated>2022-03-17T17:42:58+00:00</updated>
<author>
<name>Michael Klishin</name>
<email>michael@clojurewerkz.org</email>
</author>
<published>2022-03-17T17:36:08+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/rabbitmq-server-git.git/commit/?id=77f348f9f08e6a7af55316ba0368b3c699ad8f1d'/>
<id>77f348f9f08e6a7af55316ba0368b3c699ad8f1d</id>
<content type='text'>
Update 3.9.14 release notes

(cherry picked from commit 7eb9dd13c352821fc7835d31b40d758e1d2a5aab)
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Update 3.9.14 release notes

(cherry picked from commit 7eb9dd13c352821fc7835d31b40d758e1d2a5aab)
</pre>
</div>
</content>
</entry>
</feed>
