diff options
| author | Simon MacMullen <simon@lshift.net> | 2010-05-20 15:20:04 +0100 |
|---|---|---|
| committer | Simon MacMullen <simon@lshift.net> | 2010-05-20 15:20:04 +0100 |
| commit | 07d41db76a8817be05bca6d01e72d49b3774ca93 (patch) | |
| tree | 75fcff489a25a8ad817615bcd586591c76496e8c | |
| parent | 7fd408c58df3558aeab7860153fbf4a026441a2d (diff) | |
| download | rabbitmq-server-git-07d41db76a8817be05bca6d01e72d49b3774ca93.tar.gz | |
Cherry-pick 8f43450de344
| -rw-r--r-- | src/rabbit_amqqueue.erl | 10 | ||||
| -rw-r--r-- | src/rabbit_amqqueue_process.erl | 2 | ||||
| -rw-r--r-- | src/rabbit_channel.erl | 8 | ||||
| -rw-r--r-- | src/rabbit_tests.erl | 2 |
4 files changed, 11 insertions, 11 deletions
diff --git a/src/rabbit_amqqueue.erl b/src/rabbit_amqqueue.erl index 864b9ef31d..29d8a00c85 100644 --- a/src/rabbit_amqqueue.erl +++ b/src/rabbit_amqqueue.erl @@ -41,7 +41,7 @@ stat/1, stat_all/0, deliver/2, requeue/3, ack/4]). -export([list/1, info_keys/0, info/1, info/2, info_all/1, info_all/2]). -export([consumers/1, consumers_all/1]). --export([basic_get/3, basic_consume/8, basic_cancel/4]). +-export([basic_get/3, basic_consume/7, basic_cancel/4]). -export([notify_sent/2, unblock/2, flush_all/2]). -export([commit_all/3, rollback_all/3, notify_down_all/2, limit_all/3]). -export([on_node_down/1]). @@ -98,8 +98,8 @@ -spec(limit_all/3 :: ([pid()], pid(), pid() | 'undefined') -> ok_or_errors()). -spec(basic_get/3 :: (amqqueue(), pid(), boolean()) -> {'ok', non_neg_integer(), qmsg()} | 'empty'). --spec(basic_consume/8 :: - (amqqueue(), boolean(), pid(), pid(), pid() | 'undefined', ctag(), +-spec(basic_consume/7 :: + (amqqueue(), boolean(), pid(), pid() | 'undefined', ctag(), boolean(), any()) -> 'ok' | {'error', 'queue_owned_by_another_connection' | 'exclusive_consume_unavailable'}). @@ -302,9 +302,9 @@ limit_all(QPids, ChPid, LimiterPid) -> basic_get(#amqqueue{pid = QPid}, ChPid, NoAck) -> delegate_call(QPid, {basic_get, ChPid, NoAck}, infinity). -basic_consume(#amqqueue{pid = QPid}, NoAck, ReaderPid, ChPid, LimiterPid, +basic_consume(#amqqueue{pid = QPid}, NoAck, ChPid, LimiterPid, ConsumerTag, ExclusiveConsume, OkMsg) -> - delegate_call(QPid, {basic_consume, NoAck, ReaderPid, ChPid, + delegate_call(QPid, {basic_consume, NoAck, ChPid, LimiterPid, ConsumerTag, ExclusiveConsume, OkMsg}, infinity). diff --git a/src/rabbit_amqqueue_process.erl b/src/rabbit_amqqueue_process.erl index 468f99f413..3e63451fc6 100644 --- a/src/rabbit_amqqueue_process.erl +++ b/src/rabbit_amqqueue_process.erl @@ -612,7 +612,7 @@ handle_call({basic_get, ChPid, NoAck}, _From, reply({ok, Remaining, Msg}, State#q{backing_queue_state = BQS1}) end; -handle_call({basic_consume, NoAck, ReaderPid, ChPid, LimiterPid, +handle_call({basic_consume, NoAck, ChPid, LimiterPid, ConsumerTag, ExclusiveConsume, OkMsg}, _From, State = #q{exclusive_consumer = ExistingHolder}) -> case check_exclusive_access(ExistingHolder, ExclusiveConsume, diff --git a/src/rabbit_channel.erl b/src/rabbit_channel.erl index 6878e18488..3926d89d85 100644 --- a/src/rabbit_channel.erl +++ b/src/rabbit_channel.erl @@ -497,7 +497,7 @@ handle_method(#'basic.consume'{queue = QueueNameBin, fun (Q) -> rabbit_amqqueue:basic_consume( exclusive_access_or_locked(ReaderPid, Q), - NoAck, ReaderPid, self(), LimiterPid, + NoAck, self(), LimiterPid, ActualConsumerTag, ExclusiveConsume, ok_msg(NoWait, #'basic.consume_ok'{ consumer_tag = ActualConsumerTag})) @@ -691,9 +691,9 @@ handle_method(#'queue.declare'{queue = QueueNameBin, end, %% We use this in both branches, because queue_declare may yet return an %% existing queue. - Finish = + Finish = fun(Q) -> - case Q of + case Q of %% "equivalent" rule. NB: we don't pay attention to %% anything in the arguments table, so for the sake of the %% "equivalent" rule, all tables of arguments are @@ -711,7 +711,7 @@ handle_method(#'queue.declare'{queue = QueueNameBin, rabbit_misc:protocol_error(resource_locked, "cannot obtain exclusive access to locked ~s", [rabbit_misc:rs(QueueName)]); - #amqqueue{name = QueueName} -> + #amqqueue{name = QueueName} -> rabbit_misc:protocol_error(channel_error, "parameters for ~s not equivalent", [rabbit_misc:rs(QueueName)]) diff --git a/src/rabbit_tests.erl b/src/rabbit_tests.erl index 8064d06bfb..7afa731663 100644 --- a/src/rabbit_tests.erl +++ b/src/rabbit_tests.erl @@ -754,7 +754,7 @@ test_server_status() -> false, false, [], none) || Name <- [<<"foo">>, <<"bar">>]], - ok = rabbit_amqqueue:basic_consume(Q, true, self(), Ch, undefined, + ok = rabbit_amqqueue:basic_consume(Q, true, Ch, undefined, <<"ctag">>, true, undefined), %% list queues |
