diff options
| author | Alexey Lebedeff <alebedev@mirantis.com> | 2016-07-07 19:04:36 +0300 |
|---|---|---|
| committer | Alexey Lebedeff <alebedev@mirantis.com> | 2016-07-07 19:14:44 +0300 |
| commit | 1be5fc5eea6564552827ccd5980b2f04515cd2a2 (patch) | |
| tree | 1d8d2652d95b826ca07b043efde1471a8ab53f4a | |
| parent | 7b10a4efb35f211a2f705efdae16b3efa9c12762 (diff) | |
| download | rabbitmq-server-git-1be5fc5eea6564552827ccd5980b2f04515cd2a2.tar.gz | |
Improve logging performance
Noticed dobule atom_to_list/list_to_atom roundtrip while profiling. Not
too significant, but it still caught my eye because it was happening for
every line in log.
I think this a missing part for
https://github.com/rabbitmq/rabbitmq-common/commit/46c78094c69a769ba35bea86ed55bf6c48e8a163
And with unrolling predefined sinks it should avoid
atom_to_list/list_to_atom roundtrip completely.
| -rw-r--r-- | src/rabbit_log.erl | 12 |
1 files changed, 5 insertions, 7 deletions
diff --git a/src/rabbit_log.erl b/src/rabbit_log.erl index 1eeff96c0e..f60cf6c0c2 100644 --- a/src/rabbit_log.erl +++ b/src/rabbit_log.erl @@ -74,13 +74,11 @@ log(Category, Level, Fmt, Args) when is_list(Args) -> end, lager:log(Sink, Level, self(), Fmt, Args). -make_internal_sink_name(Category) when Category == channel; - Category == connection; - Category == mirroring; - Category == queue; - Category == federation -> - lager_util:make_internal_sink_name(list_to_atom("rabbit_" ++ - atom_to_list(Category))); +make_internal_sink_name(rabbit_log_connection) -> rabbit_log_connection_lager_event; +make_internal_sink_name(rabbit_log_channel) -> rabbit_log_channel_lager_event; +make_internal_sink_name(rabbit_log_mirroring) -> rabbit_log_mirroring_lager_event; +make_internal_sink_name(rabbit_log_queue) -> rabbit_log_queue_lager_event; +make_internal_sink_name(rabbit_log_federation) -> rabbit_log_federation_lager_event; make_internal_sink_name(Category) -> lager_util:make_internal_sink_name(Category). |