summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJean-Sébastien Pédron <jean-sebastien@rabbitmq.com>2020-04-01 12:04:05 +0200
committerGitHub <noreply@github.com>2020-04-01 12:04:05 +0200
commit429fdb272eb4ce6f64017dbb56208ea24130f6b2 (patch)
treee1e453e093d7e1d88120c75c0d6185434092f100
parenta503baf6b3c6f4112ea9f22f038b0cb1cb822e39 (diff)
parent17968ee10787d6dca41790777f6d547fb6e0be78 (diff)
downloadrabbitmq-server-git-429fdb272eb4ce6f64017dbb56208ea24130f6b2.tar.gz
Merge pull request #2294 from rabbitmq/fix-clustering_management/erlang_config
clustering_management_SUITE: No need to stop node after start_app failure in `erlang_config`
-rw-r--r--test/clustering_management_SUITE.erl15
1 files changed, 3 insertions, 12 deletions
diff --git a/test/clustering_management_SUITE.erl b/test/clustering_management_SUITE.erl
index 6a48fb17ca..e0865ca115 100644
--- a/test/clustering_management_SUITE.erl
+++ b/test/clustering_management_SUITE.erl
@@ -632,35 +632,26 @@ erlang_config(Config) ->
ok = reset(Hare),
ok = rpc:call(Hare, application, set_env,
[rabbit, cluster_nodes, {["Mike's computer"], disc}]),
- %% Rabbit app stops abnormally, node goes down
+ %% Rabbit app stops abnormally
assert_failure(fun () -> start_app(Hare) end),
assert_not_clustered(Rabbit),
%% If we use an invalid node type, the node fails to start.
- %% The Erlang VM has stopped after previous rabbit app failure
- rabbit_ct_broker_helpers:start_node(Config, Hare),
- ok = stop_app(Hare),
ok = reset(Hare),
ok = rpc:call(Hare, application, set_env,
[rabbit, cluster_nodes, {[Rabbit], blue}]),
- %% Rabbit app stops abnormally, node goes down
+ %% Rabbit app stops abnormally
assert_failure(fun () -> start_app(Hare) end),
assert_not_clustered(Rabbit),
%% If we use an invalid cluster_nodes conf, the node fails to start.
- %% The Erlang VM has stopped after previous rabbit app failure
- rabbit_ct_broker_helpers:start_node(Config, Hare),
- ok = stop_app(Hare),
ok = reset(Hare),
ok = rpc:call(Hare, application, set_env,
[rabbit, cluster_nodes, true]),
- %% Rabbit app stops abnormally, node goes down
+ %% Rabbit app stops abnormally
assert_failure(fun () -> start_app(Hare) end),
assert_not_clustered(Rabbit),
- %% The Erlang VM has stopped after previous rabbit app failure
- rabbit_ct_broker_helpers:start_node(Config, Hare),
- ok = stop_app(Hare),
ok = reset(Hare),
ok = rpc:call(Hare, application, set_env,
[rabbit, cluster_nodes, "Yes, please"]),