told dialyzer to check for more things

As Matthew suggested, I've added {wranings, [underspecs, behaiviours,
race_conditions]} to dialyzer's options.  As a result, we now have 56
warnings instead of just the 4.  Most of them are underspecs (i.e. we
say a function returns any() but dialyzer's figured out that's overly
general).

1 files changed, 6 insertions, 3 deletions

diff --git a/src/rabbit_dialyzer.erl b/src/rabbit_dialyzer.erl
index 51bd6b1f93..e5aa74b7f2 100644
--- a/src/rabbit_dialyzer.erl
+++ b/src/rabbit_dialyzer.erl
@@ -67,17 +67,20 @@ add_to_plt(PltPath, FilesString) ->
 dialyze_files(PltPath, ModifiedFiles) ->
     Files = string:tokens(ModifiedFiles, " "),
     DialyzerWarnings = dialyzer:run([{init_plt, PltPath},
-                                     {files, Files}]),
+                                     {files, Files},
+                                     {warnings, [underspecs, behaviours,
+                                                 race_conditions]}]),
     case DialyzerWarnings of
         [] -> io:format("~nOk~n"),
               ok;
-        _  -> io:format("~nFAILED with the following warnings:~n"),
+        _  -> io:format("~n~nFAILED with the following ~p warnings:~n~n",
+                        [length(DialyzerWarnings)]),
               print_warnings(DialyzerWarnings),
               fail
     end.
 
 print_warnings(Warnings) ->
-    [io:format("~s", [dialyzer:format_warning(W)]) || W <- Warnings],
+    [io:format("~s~n", [dialyzer:format_warning(W)]) || W <- Warnings],
     io:format("~n"),
     ok.