summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMichael Klishin <mklishin@pivotal.io>2016-08-18 09:38:29 +0300
committerMichael Klishin <mklishin@pivotal.io>2016-08-18 09:38:29 +0300
commit769472f9baa6bc66d77eadd1362bfc8a0bd2d33b (patch)
tree593ec77c67c9742c9ce76cff377c956d4aa43581
parent0db9986808b207466aad066f380f7f473268d6e0 (diff)
downloadrabbitmq-server-git-769472f9baa6bc66d77eadd1362bfc8a0bd2d33b.tar.gz
Use lists:foldl/3 only
-rw-r--r--src/rabbit_connection_tracking.erl19
1 files changed, 8 insertions, 11 deletions
diff --git a/src/rabbit_connection_tracking.erl b/src/rabbit_connection_tracking.erl
index 8ce32fb609..948bdc454b 100644
--- a/src/rabbit_connection_tracking.erl
+++ b/src/rabbit_connection_tracking.erl
@@ -159,7 +159,6 @@ register_connection(#tracked_connection{vhost = VHost, id = ConnId, node = Node}
%% upsert
case mnesia:dirty_read(TableName, ConnId) of
[] ->
- %% TODO: counter table
mnesia:write(TableName, Conn, write),
mnesia:dirty_update_counter(
PerVhostTableName, VHost, 1);
@@ -189,23 +188,21 @@ unregister_connection(ConnId = {Node, _Name}) when Node =:= node() ->
-spec list() -> [rabbit_types:tracked_connection()].
list() ->
- Chunks = lists:map(
- fun (Node) ->
+ Chunks = lists:foldl(
+ fun (Node, Acc) ->
Tab = tracked_connection_table_name_for(Node),
- mnesia:dirty_match_object(Tab, #tracked_connection{_ = '_'})
- end, rabbit_mnesia:cluster_nodes(running)),
- lists:foldl(fun(Chunk, Acc) -> Acc ++ Chunk end, [], Chunks).
+ Acc ++ mnesia:dirty_match_object(Tab, #tracked_connection{_ = '_'})
+ end, [], rabbit_mnesia:cluster_nodes(running)).
-spec list(rabbit_types:vhost()) -> [rabbit_types:tracked_connection()].
list(VHost) ->
- Chunks = lists:map(
- fun (Node) ->
+ Chunks = lists:foldl(
+ fun (Node, Acc) ->
Tab = tracked_connection_table_name_for(Node),
- mnesia:dirty_match_object(Tab, #tracked_connection{vhost = VHost, _ = '_'})
- end, rabbit_mnesia:cluster_nodes(running)),
- lists:foldl(fun(Chunk, Acc) -> Acc ++ Chunk end, [], Chunks).
+ Acc ++ mnesia:dirty_match_object(Tab, #tracked_connection{vhost = VHost, _ = '_'})
+ end, [], rabbit_mnesia:cluster_nodes(running)).
-spec list_on_node(node()) -> [rabbit_types:tracked_connection()].