diff options
| author | Michael Klishin <michael@novemberain.com> | 2017-02-14 23:57:25 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-02-14 23:57:25 +0300 |
| commit | 82748534acce4a9c6cf05400e1c7bed3320a6d07 (patch) | |
| tree | 69e544fa1dc109016afcaae48dc87d2eb509b5eb | |
| parent | 6f9ce6524637259c1fcede0fe2f7a4f1544ae427 (diff) | |
| parent | 1d9a24e71ef8e67c3f1fe2bfad646cf61b74d661 (diff) | |
| download | rabbitmq-server-git-82748534acce4a9c6cf05400e1c7bed3320a6d07.tar.gz | |
Merge pull request #1111 from rabbitmq/rabbitmq-top-20
Initialize core stats before any gen_server2 is started
| -rw-r--r-- | src/rabbit.erl | 4 | ||||
| -rw-r--r-- | test/priority_queue_SUITE.erl | 26 |
2 files changed, 27 insertions, 3 deletions
diff --git a/src/rabbit.erl b/src/rabbit.erl index 8bee53d5ff..f66f26c4c8 100644 --- a/src/rabbit.erl +++ b/src/rabbit.erl @@ -89,8 +89,8 @@ [{description, "core metrics storage"}, {mfa, {rabbit_sup, start_child, [rabbit_metrics]}}, - {requires, external_infrastructure}, - {enables, kernel_ready}]}). + {requires, pre_boot}, + {enables, external_infrastructure}]}). -rabbit_boot_step({rabbit_event, [{description, "statistics event manager"}, diff --git a/test/priority_queue_SUITE.erl b/test/priority_queue_SUITE.erl index 05853ebc1f..a47076b4e9 100644 --- a/test/priority_queue_SUITE.erl +++ b/test/priority_queue_SUITE.erl @@ -44,7 +44,8 @@ groups() -> resume, simple_order, straight_through, - invoke + invoke, + gen_server2_stats ]}, {cluster_size_3, [], [ mirror_queue_auto_ack, @@ -213,6 +214,29 @@ invoke(Config) -> rabbit_ct_client_helpers:close_connection(Conn), passed. + +gen_server2_stats(Config) -> + %% Synthetic test to check the invoke callback, as the bug tested here + %% is only triggered with a race condition. + %% When mirroring is stopped, the backing queue of rabbit_amqqueue_process + %% changes from rabbit_mirror_queue_master to rabbit_priority_queue, + %% which shouldn't receive any invoke call. However, there might + %% be pending messages so the priority queue receives the + %% `run_backing_queue` cast message sent to the old master. + A = rabbit_ct_broker_helpers:get_node_config(Config, 0, nodename), + {Conn, Ch} = rabbit_ct_client_helpers:open_connection_and_channel(Config, A), + Q = <<"gen_server2_stats_queue">>, + declare(Ch, Q, 3), + Pid = queue_pid(Config, A, rabbit_misc:r(<<"/">>, queue, Q)), + Metrics = rabbit_ct_broker_helpers:rpc( + Config, A, rabbit_core_metrics, get_gen_server2_stats, + [Pid]), + true = is_number(Metrics), + delete(Ch, Q), + rabbit_ct_client_helpers:close_channel(Ch), + rabbit_ct_client_helpers:close_connection(Conn), + passed. + dropwhile_fetchwhile(Config) -> {Conn, Ch} = rabbit_ct_client_helpers:open_connection_and_channel(Config, 0), Q = <<"dropwhile_fetchwhile-queue">>, |