Test gc of core metrics

2 files changed, 305 insertions, 7 deletions

diff --git a/src/rabbit_core_metrics_gc.erl b/src/rabbit_core_metrics_gc.erl
index 57c30332bd..e7f848bbc3 100644
--- a/src/rabbit_core_metrics_gc.erl
+++ b/src/rabbit_core_metrics_gc.erl
@@ -29,11 +29,11 @@ start_link() ->
     gen_server:start_link({local, ?MODULE}, ?MODULE, [], []).
 
 init(_) ->
-    Interval = rabbit_misc:get_env(rabbit, core_metrics_gc_interval, 30000),
+    Interval = rabbit_misc:get_env(rabbit, core_metrics_gc_interval, 120000),
     {ok, start_timer(#state{interval = Interval})}.
 
-handle_call(_Request, _From, State) ->
-    {noreply, State}.
+handle_call(test, _From, State) ->
+    {reply, ok, State}.
 
 handle_cast(_Request, State) ->
     {noreply, State}.
@@ -77,7 +77,7 @@ gc_queues() ->
     gc_entity(queue_coarse_metrics, GbSet),
     gc_process_and_entity(channel_queue_metrics, GbSet),
     gc_process_and_entity(consumer_created, GbSet),
-    ExchangeGbSet = gb_sets:from_list(rabbit_amqqueue:list_names()),
+    ExchangeGbSet = gb_sets:from_list(rabbit_exchange:list_names()),
     gc_process_and_entities(channel_queue_exchange_metrics, GbSet, ExchangeGbSet).
 
 gc_exchanges() ->
@@ -88,9 +88,6 @@ gc_exchanges() ->
 gc_nodes() ->
     Nodes = rabbit_mnesia:cluster_nodes(all),
     GbSet = gb_sets:from_list(Nodes),
-    gc_entity(node_persister_metrics, GbSet),
-    gc_entity(node_coarse_metrics, GbSet),
-    gc_entity(node_metrics, GbSet),
     gc_entity(node_node_metrics, GbSet).
 
 gc_gen_server2() ->
diff --git a/test/rabbit_core_metrics_gc_SUITE.erl b/test/rabbit_core_metrics_gc_SUITE.erl
new file mode 100644
index 0000000000..825f062aa7
--- /dev/null
+++ b/test/rabbit_core_metrics_gc_SUITE.erl
@@ -0,0 +1,301 @@
+%% The contents of this file are subject to the Mozilla Public License
+%% Version 1.1 (the "License"); you may not use this file except in
+%% compliance with the License. You may obtain a copy of the License
+%% at http://www.mozilla.org/MPL/
+%%
+%% Software distributed under the License is distributed on an "AS IS"
+%% basis, WITHOUT WARRANTY OF ANY KIND, either express or implied. See
+%% the License for the specific language governing rights and
+%% limitations under the License.
+%%
+%% The Original Code is RabbitMQ.
+%%
+%% The Initial Developer of the Original Code is GoPivotal, Inc.
+%% Copyright (c) 2007-2016 Pivotal Software, Inc.  All rights reserved.
+%%
+
+-module(rabbit_core_metrics_gc_SUITE).
+
+-include_lib("common_test/include/ct.hrl").
+-include_lib("eunit/include/eunit.hrl").
+-include_lib("amqp_client/include/amqp_client.hrl").
+
+-compile(export_all).
+
+all() ->
+    [
+      {group, non_parallel_tests}
+    ].
+
+groups() ->
+    [
+     {non_parallel_tests, [],
+      [ queue_metrics,
+        connection_metrics,
+        channel_metrics,
+        node_metrics,
+        gen_server2_metrics
+      ]
+     }
+    ].
+
+%% -------------------------------------------------------------------
+%% Testsuite setup/teardown.
+%% -------------------------------------------------------------------
+
+merge_app_env(Config) ->
+    rabbit_ct_helpers:merge_app_env(Config,
+                                    {rabbit, [
+                                              {core_metrics_gc_interval, 6000000},
+                                              {collect_statistics_interval, 100},
+                                              {collect_statistics, fine}
+                                             ]}).
+
+init_per_suite(Config) ->
+    rabbit_ct_helpers:log_environment(),
+    Config1 = rabbit_ct_helpers:set_config(Config, [
+                                                    {rmq_nodename_suffix, ?MODULE}
+                                                   ]),
+    rabbit_ct_helpers:run_setup_steps(
+      Config1,
+      [ fun merge_app_env/1 ] ++ rabbit_ct_broker_helpers:setup_steps()).
+
+end_per_suite(Config) ->
+    rabbit_ct_helpers:run_teardown_steps(
+      Config,
+      rabbit_ct_broker_helpers:teardown_steps()).
+
+init_per_group(_, Config) ->
+    Config.
+
+end_per_group(_, Config) ->
+    Config.
+
+init_per_testcase(Testcase, Config) ->
+    rabbit_ct_helpers:testcase_started(Config, Testcase),
+    rabbit_ct_helpers:run_steps(Config,
+                                rabbit_ct_client_helpers:setup_steps()).
+
+end_per_testcase(Testcase, Config) ->
+    rabbit_ct_helpers:testcase_finished(Config, Testcase),
+    rabbit_ct_helpers:run_teardown_steps(
+      Config,
+      rabbit_ct_client_helpers:teardown_steps()).
+
+%% -------------------------------------------------------------------
+%% Testcases.
+%% -------------------------------------------------------------------
+
+queue_metrics(Config) ->
+    A = rabbit_ct_broker_helpers:get_node_config(Config, 0, nodename),
+    Ch = rabbit_ct_client_helpers:open_channel(Config, A),
+    
+    amqp_channel:call(Ch, #'queue.declare'{queue = <<"queue_metrics">>}),
+    amqp_channel:cast(Ch, #'basic.publish'{routing_key = <<"queue_metrics">>},
+                      #amqp_msg{payload = <<"hello">>}),
+    timer:sleep(150),
+    
+    Q = q(<<"myqueue">>),
+
+    rabbit_ct_broker_helpers:rpc(Config, A, rabbit_core_metrics, queue_stats,
+                                 [Q, infos]),
+    rabbit_ct_broker_helpers:rpc(Config, A, rabbit_core_metrics, queue_stats,
+                                 [Q, 1, 1, 1, 1]),
+
+    [_] = rabbit_ct_broker_helpers:rpc(Config, A, ets, lookup,
+                                       [queue_metrics, Q]),
+    [_] = rabbit_ct_broker_helpers:rpc(Config, A, ets, lookup,
+                                       [queue_coarse_metrics, Q]),
+
+    %% Trigger gc. When the gen_server:call returns, the gc has already finished.
+    rabbit_ct_broker_helpers:rpc(Config, A, erlang, send, [rabbit_core_metrics_gc, start_gc]),
+    rabbit_ct_broker_helpers:rpc(Config, A, gen_server, call, [rabbit_core_metrics_gc, test]),    
+
+    [_|_] = rabbit_ct_broker_helpers:rpc(Config, A, ets, tab2list,
+                                         [queue_metrics]),
+    [_|_] = rabbit_ct_broker_helpers:rpc(Config, A, ets, tab2list,
+                                         [queue_coarse_metrics]),
+
+    [] = rabbit_ct_broker_helpers:rpc(Config, A, ets, lookup,
+                                      [queue_metrics, Q]),
+    [] = rabbit_ct_broker_helpers:rpc(Config, A, ets, lookup,
+                                      [queue_coarse_metrics, Q]),
+
+    amqp_channel:call(Ch, #'queue.delete'{queue = <<"queue_metrics">>}),
+    rabbit_ct_client_helpers:close_channel(Ch),
+
+    ok.
+
+connection_metrics(Config) ->
+    A = rabbit_ct_broker_helpers:get_node_config(Config, 0, nodename),
+    Ch = rabbit_ct_client_helpers:open_channel(Config, A),
+    
+    amqp_channel:call(Ch, #'queue.declare'{queue = <<"queue_metrics">>}),
+    amqp_channel:cast(Ch, #'basic.publish'{routing_key = <<"queue_metrics">>},
+                      #amqp_msg{payload = <<"hello">>}),
+    timer:sleep(200),
+    
+    DeadPid = rabbit_ct_broker_helpers:rpc(Config, A, ?MODULE, dead_pid, []),
+    
+    rabbit_ct_broker_helpers:rpc(Config, A, rabbit_core_metrics,
+                                 connection_created, [DeadPid, infos]),
+    rabbit_ct_broker_helpers:rpc(Config, A, rabbit_core_metrics,
+                                 connection_stats, [DeadPid, infos]),
+    rabbit_ct_broker_helpers:rpc(Config, A, rabbit_core_metrics,
+                                 connection_stats, [DeadPid, 1, 1, 1]),
+
+    [_] = rabbit_ct_broker_helpers:rpc(Config, A, ets, lookup,
+                                      [connection_created, DeadPid]),
+    [_] = rabbit_ct_broker_helpers:rpc(Config, A, ets, lookup,
+                                      [connection_metrics, DeadPid]),
+    [_] = rabbit_ct_broker_helpers:rpc(Config, A, ets, lookup,
+                                      [connection_coarse_metrics, DeadPid]),    
+
+    %% Trigger gc. When the gen_server:call returns, the gc has already finished.
+    rabbit_ct_broker_helpers:rpc(Config, A, erlang, send, [rabbit_core_metrics_gc, start_gc]),
+    rabbit_ct_broker_helpers:rpc(Config, A, gen_server, call, [rabbit_core_metrics_gc, test]),    
+
+    [] = rabbit_ct_broker_helpers:rpc(Config, A, ets, lookup,
+                                      [connection_created, DeadPid]),
+    [] = rabbit_ct_broker_helpers:rpc(Config, A, ets, lookup,
+                                      [connection_metrics, DeadPid]),
+    [] = rabbit_ct_broker_helpers:rpc(Config, A, ets, lookup,
+                                      [connection_coarse_metrics, DeadPid]),
+
+    [_|_] = rabbit_ct_broker_helpers:rpc(Config, A, ets, tab2list, [connection_created]),
+    [_|_] = rabbit_ct_broker_helpers:rpc(Config, A, ets, tab2list, [connection_metrics]),
+    [_|_] = rabbit_ct_broker_helpers:rpc(Config, A, ets, tab2list, [connection_coarse_metrics]),
+        
+    amqp_channel:call(Ch, #'queue.delete'{queue = <<"queue_metrics">>}),
+    rabbit_ct_client_helpers:close_channel(Ch),
+
+    ok.
+
+channel_metrics(Config) ->
+    A = rabbit_ct_broker_helpers:get_node_config(Config, 0, nodename),
+    Ch = rabbit_ct_client_helpers:open_channel(Config, A),
+    
+    amqp_channel:call(Ch, #'queue.declare'{queue = <<"queue_metrics">>}),
+    amqp_channel:cast(Ch, #'basic.publish'{routing_key = <<"queue_metrics">>},
+                      #amqp_msg{payload = <<"hello">>}),
+    {#'basic.get_ok'{}, _} = amqp_channel:call(Ch, #'basic.get'{queue = <<"queue_metrics">>,
+                                                                no_ack=true}),
+    timer:sleep(150),
+    
+    DeadPid = rabbit_ct_broker_helpers:rpc(Config, A, ?MODULE, dead_pid, []),
+    
+    Q = q(<<"myqueue">>),
+    X = x(<<"myexchange">>),
+    
+    
+    rabbit_ct_broker_helpers:rpc(Config, A, rabbit_core_metrics,
+                                 channel_created, [DeadPid, infos]),
+    rabbit_ct_broker_helpers:rpc(Config, A, rabbit_core_metrics,
+                                 channel_stats, [DeadPid, infos]),
+    rabbit_ct_broker_helpers:rpc(Config, A, rabbit_core_metrics,
+                                 channel_stats, [reductions, DeadPid, 1]),
+    rabbit_ct_broker_helpers:rpc(Config, A, rabbit_core_metrics,
+                                 channel_stats, [exchange_stats, publish,
+                                                 {DeadPid, X}, 1]),
+    rabbit_ct_broker_helpers:rpc(Config, A, rabbit_core_metrics,
+                                 channel_stats, [queue_stats, get,
+                                                 {DeadPid, Q}, 1]),
+    rabbit_ct_broker_helpers:rpc(Config, A, rabbit_core_metrics,
+                                 channel_stats, [queue_exchange_stats, publish,
+                                                 {DeadPid, {Q, X}}, 1]),
+
+    [_] = rabbit_ct_broker_helpers:rpc(Config, A, ets, lookup,
+                                       [channel_created, DeadPid]),
+    [_] = rabbit_ct_broker_helpers:rpc(Config, A, ets, lookup,
+                                       [channel_metrics, DeadPid]),
+    [_] = rabbit_ct_broker_helpers:rpc(Config, A, ets, lookup,
+                                       [channel_process_metrics, DeadPid]),
+    [_] = rabbit_ct_broker_helpers:rpc(Config, A, ets, lookup,
+                                       [channel_exchange_metrics, {DeadPid, X}]),
+    [_] = rabbit_ct_broker_helpers:rpc(Config, A, ets, lookup,
+                                      [channel_queue_metrics, {DeadPid, Q}]),
+    [_] = rabbit_ct_broker_helpers:rpc(Config, A, ets, lookup,
+                                       [channel_queue_exchange_metrics, {DeadPid, {Q, X}}]),
+    
+    %% Trigger gc. When the gen_server:call returns, the gc has already finished.
+    rabbit_ct_broker_helpers:rpc(Config, A, erlang, send, [rabbit_core_metrics_gc, start_gc]),
+    rabbit_ct_broker_helpers:rpc(Config, A, gen_server, call, [rabbit_core_metrics_gc, test]),    
+
+
+    [_|_] = rabbit_ct_broker_helpers:rpc(Config, A, ets, tab2list, [channel_created]),
+    [_|_] = rabbit_ct_broker_helpers:rpc(Config, A, ets, tab2list, [channel_metrics]),
+    [_|_] = rabbit_ct_broker_helpers:rpc(Config, A, ets, tab2list, [channel_process_metrics]),
+    [_|_] = rabbit_ct_broker_helpers:rpc(Config, A, ets, tab2list, [channel_exchange_metrics]),
+    [_|_] = rabbit_ct_broker_helpers:rpc(Config, A, ets, tab2list, [channel_queue_metrics]),
+    [_|_] = rabbit_ct_broker_helpers:rpc(Config, A, ets, tab2list, [channel_queue_exchange_metrics]),
+    
+    [] = rabbit_ct_broker_helpers:rpc(Config, A, ets, lookup,
+                                      [channel_created, DeadPid]),
+    [] = rabbit_ct_broker_helpers:rpc(Config, A, ets, lookup,
+                                      [channel_metrics, DeadPid]),
+    [] = rabbit_ct_broker_helpers:rpc(Config, A, ets, lookup,
+                                      [channel_process_metrics, DeadPid]),
+    [] = rabbit_ct_broker_helpers:rpc(Config, A, ets, lookup,
+                                      [channel_exchange_metrics, {DeadPid, X}]),
+    [] = rabbit_ct_broker_helpers:rpc(Config, A, ets, lookup,
+                                      [channel_queue_metrics, {DeadPid, Q}]),
+    [] = rabbit_ct_broker_helpers:rpc(Config, A, ets, lookup,
+                                      [channel_queue_exchange_metrics, {DeadPid, {Q, X}}]),
+    
+    amqp_channel:call(Ch, #'queue.delete'{queue = <<"queue_metrics">>}),
+    rabbit_ct_client_helpers:close_channel(Ch),
+
+    ok.
+
+node_metrics(Config) ->
+    A = rabbit_ct_broker_helpers:get_node_config(Config, 0, nodename),
+
+    rabbit_ct_broker_helpers:rpc(Config, A, rabbit_core_metrics, node_node_stats,
+                                 [{node(), 'deer@localhost'}, infos]),
+
+    [_] = rabbit_ct_broker_helpers:rpc(Config, A, ets, lookup,
+                                       [node_node_metrics, {node(), 'deer@localhost'}]),
+
+    %% Trigger gc. When the gen_server:call returns, the gc has already finished.
+    rabbit_ct_broker_helpers:rpc(Config, A, erlang, send, [rabbit_core_metrics_gc, start_gc]),
+    rabbit_ct_broker_helpers:rpc(Config, A, gen_server, call, [rabbit_core_metrics_gc, test]),
+
+    [] = rabbit_ct_broker_helpers:rpc(Config, A, ets, lookup,
+                                      [node_node_metrics, {node(), 'deer@localhost'}]),
+
+    ok.
+
+gen_server2_metrics(Config) ->
+    A = rabbit_ct_broker_helpers:get_node_config(Config, 0, nodename),
+
+    DeadPid = rabbit_ct_broker_helpers:rpc(Config, A, ?MODULE, dead_pid, []),
+
+    rabbit_ct_broker_helpers:rpc(Config, A, rabbit_core_metrics, gen_server2_stats,
+                                 [DeadPid, 1]),
+
+    [_] = rabbit_ct_broker_helpers:rpc(Config, A, ets, lookup,
+                                      [gen_server2_metrics, DeadPid]),
+
+    %% Trigger gc. When the gen_server:call returns, the gc has already finished.
+    rabbit_ct_broker_helpers:rpc(Config, A, erlang, send, [rabbit_core_metrics_gc, start_gc]),
+    rabbit_ct_broker_helpers:rpc(Config, A, gen_server, call, [rabbit_core_metrics_gc, test]),
+
+    [_|_] = rabbit_ct_broker_helpers:rpc(Config, A, ets, tab2list, [gen_server2_metrics]),
+
+    [] = rabbit_ct_broker_helpers:rpc(Config, A, ets, lookup,
+                                      [gen_server2_metrics, DeadPid]),
+
+    ok.
+
+dead_pid() ->
+    spawn(fun() -> ok end).
+
+q(Name) ->
+    #resource{ virtual_host = <<"/">>,
+               kind = queue,
+               name = Name }.
+
+x(Name) ->
+    #resource{ virtual_host = <<"/">>,
+               kind = exchange,
+               name = Name }.