diff options
| author | Alexandru Scvortov <alexandru@rabbitmq.com> | 2010-07-09 12:11:22 +0100 |
|---|---|---|
| committer | Alexandru Scvortov <alexandru@rabbitmq.com> | 2010-07-09 12:11:22 +0100 |
| commit | 861991d28252005cf24189f21d7965832da6889e (patch) | |
| tree | cae77f9092333ea27d25660847e365cc5579110d | |
| parent | 1a655af08bf4c820dbc24dbeafa65db0eb4338c0 (diff) | |
| download | rabbitmq-server-git-861991d28252005cf24189f21d7965832da6889e.tar.gz | |
replaced regexp with re
| -rw-r--r-- | src/rabbit_access_control.erl | 7 | ||||
| -rw-r--r-- | src/rabbit_dialyzer.erl | 10 | ||||
| -rw-r--r-- | src/rabbit_exchange.erl | 1 | ||||
| -rw-r--r-- | src/rabbit_exchange_type_topic.erl | 2 | ||||
| -rw-r--r-- | src/rabbit_multi.erl | 6 |
5 files changed, 16 insertions, 10 deletions
diff --git a/src/rabbit_access_control.erl b/src/rabbit_access_control.erl index 7d1839bb6e..9590d38080 100644 --- a/src/rabbit_access_control.erl +++ b/src/rabbit_access_control.erl @@ -172,9 +172,10 @@ check_resource_access(Username, [] -> false; [#user_permission{permission = P}] -> - case regexp:match( + case re:run( binary_to_list(Name), - binary_to_list(element(permission_index(Permission), P))) of + binary_to_list(element(permission_index(Permission), P)), + [{return, list}]) of {match, _, _} -> true; nomatch -> false end @@ -301,7 +302,7 @@ list_vhosts() -> validate_regexp(RegexpBin) -> Regexp = binary_to_list(RegexpBin), - case regexp:parse(Regexp) of + case re:compile(Regexp) of {ok, _} -> ok; {error, Reason} -> throw({error, {invalid_regexp, Regexp, Reason}}) end. diff --git a/src/rabbit_dialyzer.erl b/src/rabbit_dialyzer.erl index 0ec6beb676..96658d5389 100644 --- a/src/rabbit_dialyzer.erl +++ b/src/rabbit_dialyzer.erl @@ -55,8 +55,14 @@ create_basic_plt(BasicPltPath) -> dialyzer_cl:start(OptsRecord), ok. +splitIntoFilenames(FilesString) -> + lists:dropwhile(fun([]) -> true; + (_) -> false + end, + re:split(FilesString, " ", [{return, list}, trim])). + add_to_plt(PltPath, FilesString) -> - {ok, Files} = regexp:split(FilesString, " "), + Files = splitIntoFilenames(FilesString), DialyzerWarnings = dialyzer:run([{analysis_type, plt_add}, {init_plt, PltPath}, {output_plt, PltPath}, @@ -65,7 +71,7 @@ add_to_plt(PltPath, FilesString) -> ok. dialyze_files(PltPath, ModifiedFiles) -> - {ok, Files} = regexp:split(ModifiedFiles, " "), + Files = splitIntoFilenames(ModifiedFiles), DialyzerWarnings = dialyzer:run([{init_plt, PltPath}, {files, Files}]), case DialyzerWarnings of diff --git a/src/rabbit_exchange.erl b/src/rabbit_exchange.erl index 822c164d57..322841cb1e 100644 --- a/src/rabbit_exchange.erl +++ b/src/rabbit_exchange.erl @@ -49,7 +49,6 @@ -import(mnesia). -import(sets). -import(lists). --import(regexp). %%---------------------------------------------------------------------------- diff --git a/src/rabbit_exchange_type_topic.erl b/src/rabbit_exchange_type_topic.erl index a374cfee7f..ae6b20eb16 100644 --- a/src/rabbit_exchange_type_topic.erl +++ b/src/rabbit_exchange_type_topic.erl @@ -67,7 +67,7 @@ publish(#exchange{name = Name}, Delivery = Delivery). split_topic_key(Key) -> - {ok, KeySplit} = regexp:split(binary_to_list(Key), "\\."), + KeySplit = re:split(binary_to_list(Key), "\\.", [{return, list}]), KeySplit. topic_matches(PatternKey, RoutingKey) -> diff --git a/src/rabbit_multi.erl b/src/rabbit_multi.erl index 5db1d77a32..5fda588bdd 100644 --- a/src/rabbit_multi.erl +++ b/src/rabbit_multi.erl @@ -309,9 +309,9 @@ is_dead(Pid) -> {win32, fun () -> Res = os:cmd("tasklist /nh /fi \"pid eq " ++ PidS ++ "\""), - case regexp:first_match(Res, "erl.exe") of - {match, _, _} -> false; - _ -> true + case re:run(Res, "erl\\.exe") of + {match, _} -> false; + _ -> true end end}]). |
