summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPhilip Kuryloski <kuryloskip@vmware.com>2020-06-10 09:59:44 +0200
committerGitHub <noreply@github.com>2020-06-10 09:59:44 +0200
commit92cd21902560d84eeaa33d4f104214823985e477 (patch)
tree714f240e0804e181d13de8cf885955ca301cbfd7
parent8f39952913b26c6106fe0393a07f075a3020b348 (diff)
parent94370dde79d4921858c63b1b3bd3f4263690acf8 (diff)
downloadrabbitmq-server-git-92cd21902560d84eeaa33d4f104214823985e477.tar.gz
Merge pull request #2374 from rabbitmq/metrics-suite-test-stability
Make connection_metric_idemp_test example rather than property based
-rw-r--r--test/metrics_SUITE.erl10
1 files changed, 7 insertions, 3 deletions
diff --git a/test/metrics_SUITE.erl b/test/metrics_SUITE.erl
index f3e5cac5bb..2d0ed5b2d4 100644
--- a/test/metrics_SUITE.erl
+++ b/test/metrics_SUITE.erl
@@ -103,7 +103,9 @@ queue_metric_count_channel_per_queue_test(Config) ->
[Config], 5).
connection_metric_idemp_test(Config) ->
- rabbit_ct_proper_helpers:run_proper(fun prop_connection_metric_idemp/1, [Config], 25).
+ connection_metric_idemp(Config, {1, 1}),
+ connection_metric_idemp(Config, {1, 2}),
+ connection_metric_idemp(Config, {2, 2}).
channel_metric_idemp_test(Config) ->
rabbit_ct_proper_helpers:run_proper(fun prop_channel_metric_idemp/1, [Config], 25).
@@ -150,8 +152,10 @@ connection_metric_idemp(Config, {N, R}) ->
TableAfter = [ Pid || {Pid, _} <- read_table_rpc(Config, connection_metrics)],
TableAfter2 = [ Pid || {Pid, _} <- read_table_rpc(Config, connection_coarse_metrics)],
[rabbit_ct_client_helpers:close_connection(Conn) || Conn <- Conns],
- (Table2 == TableAfter2) and (Table == TableAfter) and
- (N == length(Table)) and (N == length(TableAfter)).
+ ?assertEqual(Table, TableAfter),
+ ?assertEqual(Table2, TableAfter2),
+ ?assertEqual(N, length(Table)),
+ ?assertEqual(N, length(TableAfter)).
channel_metric_idemp(Config, {N, R}) ->
Conn = rabbit_ct_client_helpers:open_unmanaged_connection(Config),