diff options
| author | Jean-Sébastien Pédron <jean-sebastien@rabbitmq.com> | 2019-11-28 11:41:58 +0100 |
|---|---|---|
| committer | Jean-Sébastien Pédron <jean-sebastien@rabbitmq.com> | 2019-11-28 11:41:58 +0100 |
| commit | a53285ef79b452e60d84ef16ee7ebd474a40bc2e (patch) | |
| tree | 6b9e8eb6ee7c273fcedb595c91270ab872f594b3 | |
| parent | b772a9ceaff671d05df3f66b532dafd8e5156183 (diff) | |
| download | rabbitmq-server-git-a53285ef79b452e60d84ef16ee7ebd474a40bc2e.tar.gz | |
feature_flags_SUITE: Check feature flag support state
... in addition to the fact they are disabled. Because a unsupported
feature flag is implicitly disabled.
| -rw-r--r-- | test/feature_flags_SUITE.erl | 54 |
1 files changed, 36 insertions, 18 deletions
diff --git a/test/feature_flags_SUITE.erl b/test/feature_flags_SUITE.erl index 25c4a93a54..f2ad26d97d 100644 --- a/test/feature_flags_SUITE.erl +++ b/test/feature_flags_SUITE.erl @@ -613,18 +613,26 @@ clustering_ok_with_ff_disabled_everywhere(Config) -> log_feature_flags_of_all_nodes(Config), case FFSubsysOk of - true -> ?assertEqual([false, false], - is_feature_flag_enabled(Config, ff_from_testsuite)); - false -> ok + true -> + ?assertEqual([true, true], + is_feature_flag_supported(Config, ff_from_testsuite)), + ?assertEqual([false, false], + is_feature_flag_enabled(Config, ff_from_testsuite)); + false -> + ok end, ?assertEqual(Config, rabbit_ct_broker_helpers:cluster_nodes(Config)), log_feature_flags_of_all_nodes(Config), case FFSubsysOk of - true -> ?assertEqual([false, false], - is_feature_flag_enabled(Config, ff_from_testsuite)); - false -> ok + true -> + ?assertEqual([true, true], + is_feature_flag_supported(Config, ff_from_testsuite)), + ?assertEqual([false, false], + is_feature_flag_enabled(Config, ff_from_testsuite)); + false -> + ok end, ok. @@ -639,18 +647,24 @@ clustering_ok_with_ff_enabled_on_some_nodes(Config) -> log_feature_flags_of_all_nodes(Config), case FFSubsysOk of - true -> ?assertEqual([true, false], - is_feature_flag_enabled(Config, ff_from_testsuite)); - false -> ok + true -> + ?assertEqual([true, true], + is_feature_flag_supported(Config, ff_from_testsuite)), + ?assertEqual([true, false], + is_feature_flag_enabled(Config, ff_from_testsuite)); + false -> + ok end, ?assertEqual(Config, rabbit_ct_broker_helpers:cluster_nodes(Config)), log_feature_flags_of_all_nodes(Config), case FFSubsysOk of - true -> ?assertEqual([true, true], - is_feature_flag_enabled(Config, ff_from_testsuite)); - false -> ok + true -> + ?assertEqual([true, true], + is_feature_flag_enabled(Config, ff_from_testsuite)); + false -> + ok end, ok. @@ -663,18 +677,22 @@ clustering_ok_with_ff_enabled_everywhere(Config) -> log_feature_flags_of_all_nodes(Config), case FFSubsysOk of - true -> ?assertEqual([true, true], - is_feature_flag_enabled(Config, ff_from_testsuite)); - false -> ok + true -> + ?assertEqual([true, true], + is_feature_flag_enabled(Config, ff_from_testsuite)); + false -> + ok end, ?assertEqual(Config, rabbit_ct_broker_helpers:cluster_nodes(Config)), log_feature_flags_of_all_nodes(Config), case FFSubsysOk of - true -> ?assertEqual([true, true], - is_feature_flag_enabled(Config, ff_from_testsuite)); - false -> ok + true -> + ?assertEqual([true, true], + is_feature_flag_enabled(Config, ff_from_testsuite)); + false -> + ok end, ok. |