summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSimon MacMullen <simon@lshift.net>2010-04-20 16:01:46 +0100
committerSimon MacMullen <simon@lshift.net>2010-04-20 16:01:46 +0100
commite394a91af44c7a6bbe03d84260f0c59e58b53a9c (patch)
tree7bc3ff1af90d4e161493a3913c91e3f63039c738
parentaf162a6fd5fbc5db1eca923b3431940e7c812600 (diff)
downloadrabbitmq-server-git-e394a91af44c7a6bbe03d84260f0c59e58b53a9c.tar.gz
Make start-secondary-cover actually do something, stop Erlang tests blowing up.
-rw-r--r--Makefile2
-rw-r--r--src/rabbit_tests.erl4
2 files changed, 5 insertions, 1 deletions
diff --git a/Makefile b/Makefile
index c0219e851c..e058a6fa1a 100644
--- a/Makefile
+++ b/Makefile
@@ -172,7 +172,7 @@ start-cover: all
echo "cover:start(), rabbit_misc:enable_cover([\"$(COVER_DIR)\"])." | $(ERL_CALL)
start-secondary-cover:
- echo "rabbit_misc:enable_cover_node(\"$(SECONDARY_NODENAME)\")." | $(ERL_CALL)
+ echo "rabbit_misc:enable_cover_node(\"$(SECONDARY_NODENAME)\")." | $(ERL_CALL)
stop-cover: all
echo "rabbit_misc:report_cover(), cover:stop()." | $(ERL_CALL)
diff --git a/src/rabbit_tests.erl b/src/rabbit_tests.erl
index 82f2d19918..d645d183d1 100644
--- a/src/rabbit_tests.erl
+++ b/src/rabbit_tests.erl
@@ -625,8 +625,12 @@ test_cluster_management2(SecondaryNode) ->
ok = control_action(stop_app, []),
%% NB: this will log an inconsistent_database error, which is harmless
+ %% Turning cover on / off is OK even if we're not in general using cover,
+ %% it just turns the engine on / off, doesn't actually log anything.
+ cover:stop([SecondaryNode]),
true = disconnect_node(SecondaryNode),
pong = net_adm:ping(SecondaryNode),
+ cover:start([SecondaryNode]),
%% leaving a cluster as a ram node
ok = control_action(reset, []),