diff options
| author | Bogdan Dobrelya <bdobrelia@mirantis.com> | 2016-01-07 13:51:40 +0100 |
|---|---|---|
| committer | Bogdan Dobrelya <bdobrelia@mirantis.com> | 2016-01-07 13:51:40 +0100 |
| commit | 0f77ae3f47fabeebdb75644e61b183daddfc3917 (patch) | |
| tree | 50a54df157f658ca6dab86698be16f714fed1b05 /scripts/rabbitmq-server-ha.ocf | |
| parent | 0c4d9a0d88e15394889e69a426cf3a8fce149257 (diff) | |
| download | rabbitmq-server-git-0f77ae3f47fabeebdb75644e61b183daddfc3917.tar.gz | |
Remove unneeded sleep for a graceful stop by PID
The sleep in not needed according to the
https://www.rabbitmq.com/man/rabbitmqctl.1.man.html
"If a pid_file is specified, also waits for the process
specified there to terminate."
Related Fuel bug https://launchpad.net/bugs/1529897
Related PR
https://github.com/rabbitmq/rabbitmq-server/pull/523
Signed-off-by: Bogdan Dobrelya <bdobrelia@mirantis.com>
Diffstat (limited to 'scripts/rabbitmq-server-ha.ocf')
| -rwxr-xr-x | scripts/rabbitmq-server-ha.ocf | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/scripts/rabbitmq-server-ha.ocf b/scripts/rabbitmq-server-ha.ocf index 5f338211d6..6cec4f1864 100755 --- a/scripts/rabbitmq-server-ha.ocf +++ b/scripts/rabbitmq-server-ha.ocf @@ -933,16 +933,12 @@ stop_server_process() { # Try to stop gracefully by known PID ocf_log info "${LH} Execute stop with timeout: ${TIMEOUT_ARG}" su_rabbit_cmd "${OCF_RESKEY_ctl} stop ${OCF_RESKEY_pid_file} 2>&1 >> \"${OCF_RESKEY_log_dir}/shutdown_log\"" - if [ $? -eq 0 ] ; then - ocf_log info "${LH} RMQ-server process (PID=${pid}) stopped succesfully." - ocf_log info "${LH} grant a graceful termintation window ${OCF_RESKEY_stop_time} to end its beam and remove pidfile" - sleep "${OCF_RESKEY_stop_time}" - fi + [ $? -eq 0 ] && ocf_log info "${LH} RMQ-server process (PID=${pid}) stopped succesfully." fi if [ -f ${OCF_RESKEY_pid_file} ] ; then # Ensure there is no beam process and pidfile left - ocf_log warn "${LH} Cannot be stopped, forcing the RMQ-server process termination" + ocf_log warn "${LH} The pidfile still exists, forcing the RMQ-server cleanup" kill_rmq_and_remove_pid fi |
