not_found error on attempt to declare a queue that exists on a stopped node

this prevents loss or duplication of messages when that node recovers

I considered returing {ok, Q} | {error, not_found} from
internal_declare (and subsequently declare), and let the channel deal
with throwing the appropriate amqp error. But
- that would be a change to a crucial internal API that is used by
quite a few extensions
- it would make the return type inconsistent with
rabbit_exchange:declare, which too only returns X, not {ok, X}.
- the rabbit_amqqueue module already knows about amqp errors - see
with_or_die. So this is not breaking any concern separation.

0 files changed, 0 insertions, 0 deletions