diff options
| author | Jean-Sébastien Pédron <jean-sebastien@rabbitmq.com> | 2019-10-07 11:45:42 +0200 |
|---|---|---|
| committer | Jean-Sébastien Pédron <jean-sebastien@rabbitmq.com> | 2019-10-07 11:45:42 +0200 |
| commit | 0332d2e30bc2498ed81c4d65b399b183e2cfa96c (patch) | |
| tree | 07e24f0da996ccf14cc50d9b8b2baa890e4521c0 /src | |
| parent | f201e562052e9963c210718e93bbdc005a58a274 (diff) | |
| download | rabbitmq-server-git-0332d2e30bc2498ed81c4d65b399b183e2cfa96c.tar.gz | |
rabbit_feature_flags: Improve comments around 3.7.x pre-feature-flags nodes
Diffstat (limited to 'src')
| -rw-r--r-- | src/rabbit_feature_flags.erl | 17 |
1 files changed, 10 insertions, 7 deletions
diff --git a/src/rabbit_feature_flags.erl b/src/rabbit_feature_flags.erl index 71c719a1b6..cdf9090cf0 100644 --- a/src/rabbit_feature_flags.erl +++ b/src/rabbit_feature_flags.erl @@ -1639,8 +1639,9 @@ does_node_support(Node, FeatureNames, Timeout) -> end, case Ret of {error, pre_feature_flags_rabbitmq} -> - %% See run_feature_flags_mod_on_remote_node/4 for an - %% explanation why we consider this node a 3.7.x node. + %% See run_feature_flags_mod_on_remote_node/4 for + %% an explanation why we consider this node a 3.7.x + %% pre-feature-flags node. rabbit_log:debug( "Feature flags: no feature flags support on node `~s`, " "consider the feature flags unsupported: ~p", @@ -1803,8 +1804,9 @@ run_feature_flags_mod_on_remote_node(Node, Function, Args, Timeout) -> {undef, [{?MODULE, Function, Args, []} | _]}}} -> - %% If rabbit_feature_flags:is_supported_locally/1 is undefined - %% on the remote node, we consider it to be a 3.7.x node. + %% If rabbit_feature_flags:Function() is undefined + %% on the remote node, we consider it to be a 3.7.x + %% pre-feature-flags node. %% %% Theoretically, it could be an older version (3.6.x and %% older). But the RabbitMQ version consistency check @@ -1813,7 +1815,7 @@ run_feature_flags_mod_on_remote_node(Node, Function, Args, Timeout) -> %% this situation from happening before we reach this point. rabbit_log:debug( "Feature flags: ~s:~s~p unavailable on node `~s`: " - "assuming it is a RabbitMQ 3.7.x node", + "assuming it is a RabbitMQ 3.7.x pre-feature-flags node", [?MODULE, Function, Args, Node]), {error, pre_feature_flags_rabbitmq}; {badrpc, Reason} = Error -> @@ -1838,8 +1840,9 @@ query_remote_feature_flags(Node, Which, Timeout) -> [Which, Node]), case run_feature_flags_mod_on_remote_node(Node, list, [Which], Timeout) of {error, pre_feature_flags_rabbitmq} -> - %% See run_feature_flags_mod_on_remote_node/4 for an - %% explanation why we consider this node a 3.7.x node. + %% See run_feature_flags_mod_on_remote_node/4 for + %% an explanation why we consider this node a 3.7.x + %% pre-feature-flags node. rabbit_log:debug( "Feature flags: no feature flags support on node `~s`, " "consider the list of feature flags empty", [Node]), |