summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorJean-Sébastien Pédron <jean-sebastien@rabbitmq.com>2020-05-11 12:35:54 +0200
committerJean-Sébastien Pédron <jean-sebastien@rabbitmq.com>2020-05-11 12:35:54 +0200
commit57a81b95a14823c3a0bc2a8f655d2b1b48c944ea (patch)
tree7f8e987a2fcc730b220e6756b90dac16f18e7d7b /src
parent4b69a3c8c7149caafe511e515f001bc0b104b76d (diff)
downloadrabbitmq-server-git-57a81b95a14823c3a0bc2a8f655d2b1b48c944ea.tar.gz
rabbit_peer_discovery: Fix type spec of lock/0
Related to this: in `rabbit_mnesia`, remove dead code from the case clause handling the return value of `rabbit_peer_discovery:lock/0`. Indeed, the function never returns `Data` only. Reported by Dialyzer.
Diffstat (limited to 'src')
-rw-r--r--src/rabbit_mnesia.erl7
-rw-r--r--src/rabbit_peer_discovery.erl2
2 files changed, 1 insertions, 8 deletions
diff --git a/src/rabbit_mnesia.erl b/src/rabbit_mnesia.erl
index 6781c1a720..b7db646dad 100644
--- a/src/rabbit_mnesia.erl
+++ b/src/rabbit_mnesia.erl
@@ -128,13 +128,6 @@ init_with_lock(Retries, Timeout, RunPeerDiscovery) ->
rabbit_peer_discovery:maybe_register()
after
rabbit_peer_discovery:unlock(Data)
- end;
- Data when is_binary(Data) or is_list(Data) ->
- try
- RunPeerDiscovery(),
- rabbit_peer_discovery:maybe_register()
- after
- rabbit_peer_discovery:unlock(Data)
end
end.
diff --git a/src/rabbit_peer_discovery.erl b/src/rabbit_peer_discovery.erl
index c2860f3b24..9c3f9f768d 100644
--- a/src/rabbit_peer_discovery.erl
+++ b/src/rabbit_peer_discovery.erl
@@ -250,7 +250,7 @@ unregister() ->
ok
end.
--spec lock() -> ok | {ok, Data :: term()} | not_supported | {error, Reason :: string()}.
+-spec lock() -> {ok, Data :: term()} | not_supported | {error, Reason :: string()}.
lock() ->
Backend = backend(),