cosmetic: don't rely on Erlang term order to catch type errors

1 files changed, 5 insertions, 6 deletions

diff --git a/src/rabbit_amqqueue.erl b/src/rabbit_amqqueue.erl
index c2724a12e2..87a7e7e4cc 100644
--- a/src/rabbit_amqqueue.erl
+++ b/src/rabbit_amqqueue.erl
@@ -355,13 +355,12 @@ check_string_argument({Type, _}, _) ->
 
 check_integer_argument(undefined, _Args) ->
     ok;
-check_integer_argument({Type, Val}, _Args) when Val > 0 ->
+check_integer_argument({Type, Val}, _Args) ->
     case lists:member(Type, ?INTEGER_ARG_TYPES) of
-        true  -> ok;
-        false -> {error, {unacceptable_type, Type}}
-    end;
-check_integer_argument({_Type, Val}, _Args) ->
-    {error, {value_zero_or_less, Val}}.
+        false              -> {error, {unacceptable_type, Type}};
+        true when Val =< 0 -> {error, {value_zero_or_less, Val}};
+        true               -> ok
+    end.
 
 check_dlxrk_argument(undefined, _Args) ->
     ok;