eliminate "Function X has no local return" dialyzer errors

4 files changed, 23 insertions, 1 deletions

diff --git a/src/rabbit.erl b/src/rabbit.erl
index 0f3c52ca67..16694105ee 100644
--- a/src/rabbit.erl
+++ b/src/rabbit.erl
@@ -533,6 +533,9 @@ sort_boot_steps(UnsortedSteps) ->
                end])
     end.
 
+-ifdef(use_specs).
+-spec(boot_error/2 :: (term(), not_available | [tuple()]) -> no_return()).
+-endif.
 boot_error(Term={error, {timeout_waiting_for_tables, _}}, _Stacktrace) ->
     AllNodes = rabbit_mnesia:cluster_nodes(all),
     {Err, Nodes} =
@@ -552,6 +555,10 @@ boot_error(Reason, Stacktrace) ->
     Args = [Reason, log_location(kernel), log_location(sasl)],
     boot_error(Reason, Fmt, Args, Stacktrace).
 
+-ifdef(use_specs).
+-spec(boot_error/4 :: (term(), string(), [any()], not_available | [tuple()])
+                      -> no_return()).
+-endif.
 boot_error(Reason, Fmt, Args, not_available) ->
     basic_boot_error(Reason, Fmt, Args);
 boot_error(Reason, Fmt, Args, Stacktrace) ->
diff --git a/src/rabbit_channel.erl b/src/rabbit_channel.erl
index 88e3dfc583..2b89be8ff5 100644
--- a/src/rabbit_channel.erl
+++ b/src/rabbit_channel.erl
@@ -412,8 +412,14 @@ handle_exception(Reason, State = #ch{protocol   = Protocol,
             {stop, normal, State1}
     end.
 
+-ifdef(use_specs).
+-spec(precondition_failed/1 :: (string()) -> no_return()).
+-endif.
 precondition_failed(Format) -> precondition_failed(Format, []).
 
+-ifdef(use_specs).
+-spec(precondition_failed/2 :: (string(), [any()]) -> no_return()).
+-endif.
 precondition_failed(Format, Params) ->
     rabbit_misc:protocol_error(precondition_failed, Format, Params).
 
diff --git a/src/rabbit_exchange_type_invalid.erl b/src/rabbit_exchange_type_invalid.erl
index 101fe434e9..c5d781c2ed 100644
--- a/src/rabbit_exchange_type_invalid.erl
+++ b/src/rabbit_exchange_type_invalid.erl
@@ -31,6 +31,10 @@ description() ->
 
 serialise_events() -> false.
 
+-ifdef(use_specs).
+-spec(route/2 :: (rabbit_types:exchange(), rabbit_types:delivery())
+                 -> no_return()).
+-endif.
 route(#exchange{name = Name, type = Type}, _) ->
     rabbit_misc:protocol_error(
       precondition_failed,
diff --git a/src/rabbit_reader.erl b/src/rabbit_reader.erl
index 13459350cf..ae8327498e 100644
--- a/src/rabbit_reader.erl
+++ b/src/rabbit_reader.erl
@@ -1007,7 +1007,12 @@ emit_stats(State) ->
     rabbit_event:reset_stats_timer(State, #v1.stats_timer).
 
 %% 1.0 stub
-
+-ifdef(use_specs).
+-spec(become_1_0/3 :: ('amqp' | 'sasl',
+                       {non_neg_integer(), non_neg_integer(),
+                        non_neg_integer(), non_neg_integer()},
+                       #v1{}) -> no_return()).
+-endif.
 become_1_0(Mode, Version, State = #v1{sock = Sock}) ->
     case code:is_loaded(rabbit_amqp1_0_reader) of
         false -> refuse_connection(Sock, {bad_version, Version});