diff options
| author | Michael Klishin <michael@clojurewerkz.org> | 2018-06-05 19:06:38 +0300 |
|---|---|---|
| committer | Michael Klishin <mklishin@pivotal.io> | 2018-06-06 15:39:05 +0300 |
| commit | a210d82f54a133eae167da036302c1c63b3d4d9a (patch) | |
| tree | 7e0384d67edd40c08458e0de7afdb597001113be /src | |
| parent | ed40ab692930349c04d42df370e9b6a5681dd711 (diff) | |
| download | rabbitmq-server-git-a210d82f54a133eae167da036302c1c63b3d4d9a.tar.gz | |
Don't await for error_logger handlers to initialise
It will never be started on OTP 21.
The problem this piece of code originally was added to solve
is not very relevant now that we use Lager. Arguably connection
rate throttling should be enforced elsewhere, be it Ranch or a proxy/load balancer.
In any case, this particular implementation worked around an error_logger
issue that is no longer problematic for us, and eventually won't be problematic
for the entire ecosystem because OTP 21 introduced a completely new logger.
Cherry-picked per discussion with @dumbbell and @lukebakken.
[#157964874]
(cherry picked from commit a54b44fd8d24af90d8df301658fba4775f957bc8)
Diffstat (limited to 'src')
| -rw-r--r-- | src/rabbit_reader.erl | 9 |
1 files changed, 0 insertions, 9 deletions
diff --git a/src/rabbit_reader.erl b/src/rabbit_reader.erl index 9127fa530d..50d7d7e5b2 100644 --- a/src/rabbit_reader.erl +++ b/src/rabbit_reader.erl @@ -181,15 +181,6 @@ start_link(HelperSup, Ref, Sock) -> Pid = proc_lib:spawn_link(?MODULE, init, [self(), HelperSup, Ref, Sock]), - %% In the event that somebody floods us with connections, the - %% reader processes can spew log events at error_logger faster - %% than it can keep up, causing its mailbox to grow unbounded - %% until we eat all the memory available and crash. So here is a - %% meaningless synchronous call to the underlying gen_event - %% mechanism. When it returns the mailbox is drained, and we - %% return to our caller to accept more connections. - gen_event:which_handlers(error_logger), - {ok, Pid}. shutdown(Pid, Explanation) -> |