summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorMatthew Sackman <matthew@lshift.net>2010-04-23 11:40:18 +0100
committerMatthew Sackman <matthew@lshift.net>2010-04-23 11:40:18 +0100
commitc0d68bdbcad03b27f0d8d0ad6c552bd645606e08 (patch)
tree5a50bfb90ecef7c4d7ebfdd8a48abfcf8c79e914 /src
parent92e5da9c6f30dafdf3ece603f0563a2c4866f66f (diff)
parent1bbba45fd6e09989da671c4454a31098b3f6ef04 (diff)
downloadrabbitmq-server-git-c0d68bdbcad03b27f0d8d0ad6c552bd645606e08.tar.gz
Merging default into bug 21673
Diffstat (limited to 'src')
-rw-r--r--src/rabbit_misc.erl6
-rw-r--r--src/rabbit_tests.erl4
2 files changed, 10 insertions, 0 deletions
diff --git a/src/rabbit_misc.erl b/src/rabbit_misc.erl
index 028b0d73ea..2c1808465f 100644
--- a/src/rabbit_misc.erl
+++ b/src/rabbit_misc.erl
@@ -43,6 +43,7 @@
-export([r/3, r/2, r_arg/4, rs/1]).
-export([enable_cover/0, report_cover/0]).
-export([enable_cover/1, report_cover/1]).
+-export([start_cover/1]).
-export([throw_on_error/2, with_exit_handler/2, filter_exit_map/2]).
-export([with_user/2, with_vhost/2, with_user_and_vhost/3]).
-export([execute_mnesia_transaction/1]).
@@ -97,6 +98,7 @@
undefined | r(K) when is_subtype(K, atom())).
-spec(rs/1 :: (r(atom())) -> string()).
-spec(enable_cover/0 :: () -> ok_or_error()).
+-spec(start_cover/1 :: ([{string(), string()} | string()]) -> 'ok').
-spec(report_cover/0 :: () -> 'ok').
-spec(enable_cover/1 :: (file_path()) -> ok_or_error()).
-spec(report_cover/1 :: (file_path()) -> 'ok').
@@ -228,6 +230,10 @@ enable_cover(Root) ->
_ -> ok
end.
+start_cover(NodesS) ->
+ {ok, _} = cover:start([makenode(N) || N <- NodesS]),
+ ok.
+
report_cover() ->
report_cover(".").
diff --git a/src/rabbit_tests.erl b/src/rabbit_tests.erl
index 6b5c73bb90..4e89382433 100644
--- a/src/rabbit_tests.erl
+++ b/src/rabbit_tests.erl
@@ -714,8 +714,12 @@ test_cluster_management2(SecondaryNode) ->
ok = control_action(stop_app, []),
%% NB: this will log an inconsistent_database error, which is harmless
+ %% Turning cover on / off is OK even if we're not in general using cover,
+ %% it just turns the engine on / off, doesn't actually log anything.
+ cover:stop([SecondaryNode]),
true = disconnect_node(SecondaryNode),
pong = net_adm:ping(SecondaryNode),
+ cover:start([SecondaryNode]),
%% leaving a cluster as a ram node
ok = control_action(reset, []),